Re: [net-next 4/7] net/mlx5e: Refactor TIR configuration function

2018-12-05 Thread Saeed Mahameed
On Wed, 2018-12-05 at 10:56 -0800, Cong Wang wrote: > On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed > wrote: > > +static const struct mlx5e_tirc_config > > +tirc_default_config[MLX5E_NUM_INDIR_TIRS] = { > > Is it okay to define an array in a header??? No link error??? > > I must be dumb... Yes

Re: [net-next 4/7] net/mlx5e: Refactor TIR configuration function

2018-12-05 Thread Cong Wang
On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed wrote: > +static const struct mlx5e_tirc_config > +tirc_default_config[MLX5E_NUM_INDIR_TIRS] = { Is it okay to define an array in a header??? No link error??? I must be dumb...

[net-next 4/7] net/mlx5e: Refactor TIR configuration function

2018-12-04 Thread Saeed Mahameed
From: Aya Levin Refactor mlx5e_build_indir_tir_ctx_hash for better code re-use. TIR stands for Transport Interface Receive, which is responsible for all transport related operations on the receive side. Added a static array with TIR default configuration values. This separates configuration value