Re: [net-next 3/3] net: mscc: ocelot: support PTP Sync one-step timestamping

2021-04-20 Thread Vladimir Oltean
On Tue, Apr 20, 2021 at 07:33:39AM +, Y.b. Lu wrote: > > > + /* For two-step timestamp, retrieve ptp_cmd in DSA_SKB_CB_PRIV > > > + * and timestamp ID in clone->cb[0]. > > > + * For one-step timestamp, retrieve ptp_cmd in DSA_SKB_CB_PRIV. > > > + */ > > > + u8 *ptp_cmd = DSA_SKB_CB_PRIV(skb)

RE: [net-next 3/3] net: mscc: ocelot: support PTP Sync one-step timestamping

2021-04-20 Thread Y.b. Lu
; Vivien Didelot ; Florian > Fainelli ; Claudiu Manoil ; > Alexandre Belloni ; > unglinuxdri...@microchip.com; linux-...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [net-next 3/3] net: mscc: ocelot: support PTP Sync one-step > timestamping > > On Fri

Re: [net-next 3/3] net: mscc: ocelot: support PTP Sync one-step timestamping

2021-04-18 Thread Vladimir Oltean
On Fri, Apr 16, 2021 at 08:36:55PM +0800, Yangbo Lu wrote: > Although HWTSTAMP_TX_ONESTEP_SYNC existed in ioctl for hardware timestamp > configuration, the PTP Sync one-step timestamping had never been supported. > > This patch is to truely support it. Actually the ocelot switchdev driver does su

Re: [net-next 3/3] net: mscc: ocelot: support PTP Sync one-step timestamping

2021-04-16 Thread kernel test robot
Hi Yangbo, I love your patch! Yet something to improve: [auto build test ERROR on 392c36e5be1dee19ffce8c8ba8f07f90f5aa3f7c] url: https://github.com/0day-ci/linux/commits/Yangbo-Lu/Support-ocelot-PTP-Sync-one-step-timestamping/20210416-20 base: 392c36e5be1dee19ffce8c8ba8f07f90f5aa3f7c c

[net-next 3/3] net: mscc: ocelot: support PTP Sync one-step timestamping

2021-04-16 Thread Yangbo Lu
Although HWTSTAMP_TX_ONESTEP_SYNC existed in ioctl for hardware timestamp configuration, the PTP Sync one-step timestamping had never been supported. This patch is to truely support it. The hardware timestamp request type is stored in DSA_SKB_CB_PRIV first byte per skb, so that corresponding confi