Re: [net-next 2/3] tipc: make node number calculation reproducible

2020-11-24 Thread kernel test robot
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/jmaloy-redhat-com/tipc-some-minor-improvements/20201125-013225 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d5a05e69a

Re: [net-next 2/3] tipc: make node number calculation reproducible

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 12:28:33 -0500 jma...@redhat.com wrote: > +static inline u32 hash128to32(char *bytes) > +{ > + u32 res, *tmp = (u32 *)bytes; > + > + res = ntohl(tmp[0] ^ tmp[1] ^ tmp[2] ^ tmp[3]); > + if (likely(res)) > + return res; > + res = tmp[0] | tmp[1] | tmp[2

[net-next 2/3] tipc: make node number calculation reproducible

2020-11-24 Thread jmaloy
From: Jon Maloy The 32-bit node number, aka node hash or node address, is calculated based on the 128-bit node identity when it is not set explicitly by the user. In future commits we will need to perform this hash operation on peer nodes while feeling safe that we obtain the same result. We do