RE: [net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool

2017-03-21 Thread Keller, Jacob E
ogre...@redhat.com > Subject: Re: [net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool > > Hello! > > On 3/21/2017 2:47 AM, Jeff Kirsher wrote: > > > From: Jacob Keller > > > > Refactor the exit flow of the i40e_add_fdir_ethtool function. Move the &g

Re: [net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool

2017-03-21 Thread Sergei Shtylyov
Hello! On 3/21/2017 2:47 AM, Jeff Kirsher wrote: From: Jacob Keller Refactor the exit flow of the i40e_add_fdir_ethtool function. Move the input_label to the end of the function, removing the dependency on I don't see 'input_label' anywhere. Perhaps 'free_input' label was meant? having

[net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool

2017-03-20 Thread Jeff Kirsher
From: Jacob Keller Refactor the exit flow of the i40e_add_fdir_ethtool function. Move the input_label to the end of the function, removing the dependency on having a non-zero return value. Add a comment explaining why it is ok not to free the fdir data structure, because the structure is now stor