Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-02 Thread Boris Pismenny
On 7/2/2018 6:32 PM, Alexander Duyck wrote: On Mon, Jul 2, 2018 at 7:46 AM Willem de Bruijn > wrote: On Mon, Jul 2, 2018 at 9:34 AM Willem de Bruijn mailto:willemdebruijn.ker...@gmail.com>> wrote: > > On Mon, Jul 2, 2018 at 1:30 AM

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-02 Thread Willem de Bruijn
On Mon, Jul 2, 2018 at 9:34 AM Willem de Bruijn wrote: > > On Mon, Jul 2, 2018 at 1:30 AM Boris Pismenny wrote: > > > > > > > > On 7/2/2018 4:45 AM, Willem de Bruijn wrote: > > >>> I've noticed that we could get cleaner code in our driver if we remove > > >>> these two lines from net/ipv4/udp_off

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-02 Thread Willem de Bruijn
On Mon, Jul 2, 2018 at 1:30 AM Boris Pismenny wrote: > > > > On 7/2/2018 4:45 AM, Willem de Bruijn wrote: > >>> I've noticed that we could get cleaner code in our driver if we remove > >>> these two lines from net/ipv4/udp_offload.c: > >>> if (skb_is_gso(segs)) > >>>mss *= skb_shin

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-01 Thread Boris Pismenny
On 7/2/2018 4:45 AM, Willem de Bruijn wrote: I've noticed that we could get cleaner code in our driver if we remove these two lines from net/ipv4/udp_offload.c: if (skb_is_gso(segs)) mss *= skb_shinfo(segs)->gso_segs; I think that this is correct in case of GSO_PARTIAL segmenta

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-01 Thread Willem de Bruijn
>> I've noticed that we could get cleaner code in our driver if we remove >> these two lines from net/ipv4/udp_offload.c: >> if (skb_is_gso(segs)) >> mss *= skb_shinfo(segs)->gso_segs; >> >> I think that this is correct in case of GSO_PARTIAL segmentation for the >> following reasons:

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-06-30 Thread Boris Pismenny
On 06/30/18 19:06, Boris Pismenny wrote: On 06/30/18 01:19, Willem de Bruijn wrote: On Fri, Jun 29, 2018 at 2:24 AM Saeed Mahameed wrote: From: Boris Pismenny This patch enables UDP GSO support. We enable this by using two WQEs the first is a UDP LSO WQE for all segments with equal lengt

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-06-30 Thread Boris Pismenny
On 06/30/18 01:19, Willem de Bruijn wrote: On Fri, Jun 29, 2018 at 2:24 AM Saeed Mahameed wrote: From: Boris Pismenny This patch enables UDP GSO support. We enable this by using two WQEs the first is a UDP LSO WQE for all segments with equal length, and the second is for the last segment i

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-06-29 Thread Willem de Bruijn
On Fri, Jun 29, 2018 at 2:24 AM Saeed Mahameed wrote: > > From: Boris Pismenny > > This patch enables UDP GSO support. We enable this by using two WQEs > the first is a UDP LSO WQE for all segments with equal length, and the > second is for the last segment in case it has different length. > Due

[net-next 01/12] net/mlx5e: Add UDP GSO support

2018-06-28 Thread Saeed Mahameed
From: Boris Pismenny This patch enables UDP GSO support. We enable this by using two WQEs the first is a UDP LSO WQE for all segments with equal length, and the second is for the last segment in case it has different length. Due to HW limitation, before sending, we must adjust the packet length f