Re: [net-next 0/4] devlink flash update overwrite mask

2020-07-31 Thread Jacob Keller
On 7/30/2020 5:39 PM, Jakub Kicinski wrote: > LGTM, > > minor suggestions: > - could you add opt-in support flags to struct devlink_ops, a'la >ethtool_ops->supported_coalesce_params so that you don't have to >modify all drivers to reject unsupported things? Sure that makes sense. >

Re: [net-next 0/4] devlink flash update overwrite mask

2020-07-30 Thread Jakub Kicinski
LGTM, minor suggestions: - could you add opt-in support flags to struct devlink_ops, a'la ethtool_ops->supported_coalesce_params so that you don't have to modify all drivers to reject unsupported things? - could you split patch 2 into an ice change and a devlink core change?

[net-next 0/4] devlink flash update overwrite mask

2020-07-30 Thread Jacob Keller
This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a u32 value that represents a bitmask of which subsections of flash to request/allow overwriting when performing a flash update. The intent is to support the