Re: devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-17 Thread Jacob Keller
On 11/14/2020 8:10 PM, Jakub Kicinski wrote: > On Fri, 13 Nov 2020 14:51:36 -0800 Jacob Keller wrote: >> On 11/13/2020 2:32 PM, Jacob Keller wrote: >>> >>> >>> On 11/13/2020 1:34 PM, Jacob Keller wrote: Well, at least with ice, the experience is pretty bad. I tried out with a garbage

Re: devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 14:51:36 -0800 Jacob Keller wrote: > On 11/13/2020 2:32 PM, Jacob Keller wrote: > > > > > > On 11/13/2020 1:34 PM, Jacob Keller wrote: > >> Well, at least with ice, the experience is pretty bad. I tried out with > >> a garbage file name on one of my test systems. This was on

Re: devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-13 Thread Jacob Keller
On 11/13/2020 2:32 PM, Jacob Keller wrote: > > > On 11/13/2020 1:34 PM, Jacob Keller wrote: >> Well, at least with ice, the experience is pretty bad. I tried out with >> a garbage file name on one of my test systems. This was on a slightly >> older kernel without this patch applied, and the de

devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-13 Thread Jacob Keller
On 11/13/2020 1:34 PM, Jacob Keller wrote: > Well, at least with ice, the experience is pretty bad. I tried out with > a garbage file name on one of my test systems. This was on a slightly > older kernel without this patch applied, and the device had a pending > update that had not yet been fina

Re: [net-next] devlink: move request_firmware out of driver

2020-11-13 Thread Jacob Keller
On 11/13/2020 1:12 PM, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 16:01:42 -0800 Jacob Keller wrote: >> All drivers which implement the devlink flash update support, with the >> exception of netdevsim, use either request_firmware or >> request_firmware_direct to locate the firmware file. Rather

Re: [net-next] devlink: move request_firmware out of driver

2020-11-13 Thread Jakub Kicinski
On Thu, 12 Nov 2020 16:01:42 -0800 Jacob Keller wrote: > All drivers which implement the devlink flash update support, with the > exception of netdevsim, use either request_firmware or > request_firmware_direct to locate the firmware file. Rather than having > each driver do this separately as part

[net-next] devlink: move request_firmware out of driver

2020-11-12 Thread Jacob Keller
All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_update implementation, perform the request_firmw