Quoting Joe Perches :
[]
> > +/*
> > + * Ignore the position of the arguments req->id.idiag_dport and
> > + * req->id.idiag_sport in both calls to inet_lookup() and
inet6_lookup()
> > + * functions, once this is a locked in behavior exposed to user space.
> > + * Changing this will break thi
Hi Joe,
Quoting Joe Perches :
On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote:
From: "Gustavo A. R. Silva"
Date: Thu, 04 May 2017 11:07:54 -0500
> While looking into Coverity ID 1357474 I ran into the following piece
> of code at net/ipv4/inet_diag.c:392:
Because it's been this way si
On Thu, 2017-05-04 at 14:15 -0500, Gustavo A. R. Silva wrote:
> Quoting Joe Perches :
>
> > On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
> > > Regarding the code comments, what about the following patch:
> >
> > []
> > > diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
>
Quoting Joe Perches :
On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
Regarding the code comments, what about the following patch:
[]
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
[]
@@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct
sk_buff *skb,
On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
> Regarding the code comments, what about the following patch:
[]
> diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
[]
> @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct
> sk_buff *skb,
>
On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote:
> From: "Gustavo A. R. Silva"
> Date: Thu, 04 May 2017 11:07:54 -0500
>
> > While looking into Coverity ID 1357474 I ran into the following piece
> > of code at net/ipv4/inet_diag.c:392:
>
> Because it's been this way since at least 2005, it
Hi David,
Quoting David Miller :
From: "Gustavo A. R. Silva"
Date: Thu, 04 May 2017 11:07:54 -0500
While looking into Coverity ID 1357474 I ran into the following piece
of code at net/ipv4/inet_diag.c:392:
Because it's been this way since at least 2005, it doesn't matter if
the order is co
From: "Gustavo A. R. Silva"
Date: Thu, 04 May 2017 11:07:54 -0500
> While looking into Coverity ID 1357474 I ran into the following piece
> of code at net/ipv4/inet_diag.c:392:
Because it's been this way since at least 2005, it doesn't matter if
the order is correct or not. What's there is the
Hello everybody,
While looking into Coverity ID 1357474 I ran into the following piece
of code at net/ipv4/inet_diag.c:392:
struct sock *inet_diag_find_one_icsk(struct net *net,
struct inet_hashinfo *hashinfo,
const st
