Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-08 Thread Jeff Kirsher
On Wed, 2019-08-07 at 15:08 +0900, Taehee Yoo wrote: > On Wed, 7 Aug 2019 at 08:36, David Miller > wrote: > > Hi David > Thank you for the review! > > > From: Jeff Kirsher > > Date: Mon, 5 Aug 2019 13:04:03 -0700 > > > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > > b/dri

Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-06 Thread Taehee Yoo
On Wed, 7 Aug 2019 at 08:36, David Miller wrote: > Hi David Thank you for the review! > From: Jeff Kirsher > Date: Mon, 5 Aug 2019 13:04:03 -0700 > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > index cbaf712d6529..3386e7

Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-06 Thread David Miller
From: Jeff Kirsher Date: Mon, 5 Aug 2019 13:04:03 -0700 > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index cbaf712d6529..3386e752e458 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/int

[net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-05 Thread Jeff Kirsher
From: Taehee Yoo ixgbe_service_task() calls unregister_netdev() under rtnl_lock(). But unregister_netdev() internally calls rtnl_lock(). So deadlock would occur. Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode") Signed-off-by: Taehee Yoo Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher