On Thu, 4 Apr 2019 10:08:45 -0400
Matt Ellison wrote:
> Interfaces take a 'if_id' which is an interface id which can be set on
> an xfrm policy as its interface lookup key (XFRMA_IF_ID).
>
> Signed-off-by: Matt Ellison
Looks good, applied.
Extra credit for making a test.
> One comment. It seems to accept -ve value for if_id and quietly set
> to 0 may be throw an error for -ve values? or take it as u32?
> in my opinion setting to 0 is confusing
Ah good catch. I'll add the check in my version.
--
Please be advised that this email may contain confidential info
Tested-by: Antony Antony
On Fri, Apr 05, 2019 at 03:46:02PM -0400, Matt Ellison wrote:
> I recently submitted v3 of the patch, please take a look there.
great. I am testing v3 now.
One comment. It seems to accept -ve value for if_id and quietly set to 0
may be throw an error for -ve values? o
I recently submitted v3 of the patch, please take a look there.
> Question: is it easy to add "if_id" to "ip link show" output?
Yes, it should show up under the detailed output for the interface (-d).
- Matt
--
Please be advised that this email may contain confidential information.
If you
Tested-by: Antony Antony
Question: is it easy to add "if_id" to "ip link show" output?
currently:
ip link show ipsec0
4: ipsec0@eth1: mtu 1500 qdisc noqueue state UNKNOWN mode
DEFAULT group default qlen 1000
link/none da:25:61:2e:0c:98 brd ff:ff:ff:ff:ff:ff
proposed:
4: ipsec0@eth1: mtu 1
Interfaces take a 'if_id' which is an interface id which can be set on
an xfrm policy as its interface lookup key (XFRMA_IF_ID).
Signed-off-by: Matt Ellison
---
My apologies for taking so long to get v3 out:
v3 Changes:
* Only set IF_ID if set on command line.
ip/Makefile
On 1/21/19 10:05 AM, Matt Ellison wrote:
> On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern wrote:
>
>> You always add IF_ID even if not set by user. The kernel code does not
>> appear to require it so why pass a default value?
>
> 0 (the default) is a valid IF_ID, so setting an interface with a n
On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern wrote:
> You always add IF_ID even if not set by user. The kernel code does not
> appear to require it so why pass a default value?
0 (the default) is a valid IF_ID, so setting an interface with a non-zero IF_ID
back to 0 is possible. I think the b
On 1/17/19 7:40 AM, Matt Ellison wrote:
> +static int xfrm_parse_opt(struct link_util *lu, int argc, char **argv,
> + struct nlmsghdr *n)
> +{
> + unsigned int link = 0;
> + __u32 if_id = 0;
> +
> + while (argc > 0) {
> + if (!matches(*argv, "dev")) {
>
Interfaces take a 'if_id' which is an interface id which can be set on
an xfrm policy as its interface lookup key (XFRMA_IF_ID).
Signed-off-by: Matt Ellison
---
ip/Makefile | 2 +-
ip/iplink.c | 3 +-
ip/link_xfrm.c
Support for new (4.19+) xfrm virtual interfaces.
Interfaces take a 'if_id' which is an interface id which can be set on
an xfrm policy as its interface lookup key (XFRMA_IF_ID).
Signed-off-by: Matt Ellison
---
ip/Makefile | 2 +-
ip/iplink.c
On Fri, 28 Dec 2018 10:32:11 -0500
Matt Ellison wrote:
> Support for new (4.19+) xfrm virtual interfaces.
>
> Interfaces take a 'if_id' which is an interface id which can be set on
> an xfrm policy as its interface lookup key (XFRMA_IF_ID).
>
> Signed-off-by: Matt Ellison
Wanted to apply this
Support for new (4.19+) xfrm virtual interfaces.
Interfaces take a 'if_id' which is an interface id which can be set on
an xfrm policy as its interface lookup key (XFRMA_IF_ID).
Signed-off-by: Matt Ellison
---
ip/Makefile| 2 +-
ip/iplink.c| 3 +-
ip/link_xfrm.c | 90 +
13 matches
Mail list logo
