Re: [bpf PATCH v3 0/8] sockmap/tls fixes

2019-07-16 Thread Jakub Kicinski
On Mon, 15 Jul 2019 13:49:01 -0700, John Fastabend wrote: > Resolve a series of splats discovered by syzbot and an unhash > TLS issue noted by Eric Dumazet. I spent most of today poking at this set, and I'll continue tomorrow. I'm not capitulating yet, but if I can't get it to work for tls_device

[bpf PATCH v3 0/8] sockmap/tls fixes

2019-07-15 Thread John Fastabend
Resolve a series of splats discovered by syzbot and an unhash TLS issue noted by Eric Dumazet. The main issues revolved around interaction between TLS and sockmap tear down. TLS and sockmap could both reset sk->prot ops creating a condition where a close or unhash op could be called forever. A rar