Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-23 Thread Jesper Dangaard Brouer
On Mon, 23 Apr 2018 14:08:02 -0600 Alexei Starovoitov wrote: > On Mon, Apr 23, 2018 at 04:08:36PM +0200, Sebastiano Miano wrote: > > > > That's in fact the real use case for the first two patches. Since bpf > > tracepoints are still a rather common (and easy to use) troubleshooting and > > monit

Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-23 Thread Alexei Starovoitov
On Mon, Apr 23, 2018 at 04:08:36PM +0200, Sebastiano Miano wrote: > > That's in fact the real use case for the first two patches. Since bpf > tracepoints are still a rather common (and easy to use) troubleshooting and > monitoring tool why shouldn't we "enhance" their support with the newly > adde

Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-23 Thread Sebastiano Miano
On 20/04/2018 11:47, Jesper Dangaard Brouer wrote: On Thu, 19 Apr 2018 17:27:37 -0700 Alexei Starovoitov wrote: On Wed, Apr 18, 2018 at 05:30:59PM +0200, Sebastiano Miano wrote: This patch adds a sample program, called trace_map_events, that shows how to capture map events and filter them bas

Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-20 Thread Jesper Dangaard Brouer
On Thu, 19 Apr 2018 17:27:37 -0700 Alexei Starovoitov wrote: > On Wed, Apr 18, 2018 at 05:30:59PM +0200, Sebastiano Miano wrote: > > This patch adds a sample program, called trace_map_events, > > that shows how to capture map events and filter them based on > > the map id. > ... > > +struct bpf

Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-19 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 05:30:59PM +0200, Sebastiano Miano wrote: > This patch adds a sample program, called trace_map_events, > that shows how to capture map events and filter them based on > the map id. ... > +struct bpf_map_keyval_ctx { > + u64 pad;// First 8 bytes are not ac

Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-19 Thread Jesper Dangaard Brouer
On Wed, 18 Apr 2018 17:30:59 +0200 Sebastiano Miano wrote: > This patch adds a sample program, called trace_map_events, > that shows how to capture map events and filter them based on > the map id. > > The program accepts a list of map IDs, via the -i command line > option, and filters all the m

[bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-18 Thread Sebastiano Miano
This patch adds a sample program, called trace_map_events, that shows how to capture map events and filter them based on the map id. The program accepts a list of map IDs, via the -i command line option, and filters all the map events related to those IDs (i.e., map_create/update/lookup/next_key).