Re: [bpf-next] bpf: fix error check in bpf_tcp_gen_syncookie

2019-08-30 Thread Daniel Borkmann
On 8/28/19 1:46 AM, Petar Penkov wrote: From: Petar Penkov If a SYN cookie is not issued by tcp_v#_gen_syncookie, then the return value will be exactly 0, rather than <= 0. Let's change the check to reflect that, especially since mss is an unsigned value and cannot be negative. Fixes: 70d66244

Re: [bpf-next] bpf: fix error check in bpf_tcp_gen_syncookie

2019-08-28 Thread Song Liu
On Tue, Aug 27, 2019 at 4:46 PM Petar Penkov wrote: > > From: Petar Penkov > > If a SYN cookie is not issued by tcp_v#_gen_syncookie, then the return > value will be exactly 0, rather than <= 0. Let's change the check to > reflect that, especially since mss is an unsigned value and cannot be > ne

[bpf-next] bpf: fix error check in bpf_tcp_gen_syncookie

2019-08-27 Thread Petar Penkov
From: Petar Penkov If a SYN cookie is not issued by tcp_v#_gen_syncookie, then the return value will be exactly 0, rather than <= 0. Let's change the check to reflect that, especially since mss is an unsigned value and cannot be negative. Fixes: 70d66244317e ("bpf: add bpf_tcp_gen_syncookie help