Re: [bpf-next,v3,11/13] tools: bpf: make use of reallocarray

2018-07-13 Thread Jakub Kicinski
On Fri, 13 Jul 2018 17:31:34 -0700, Guenter Roeck wrote: > On 07/13/2018 05:07 PM, Jakub Kicinski wrote: > > On Fri, 13 Jul 2018 16:53:05 -0700, Guenter Roeck wrote: > >> Hi, > >> > >> On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote: > >>> reallocarray() is a safer variant of rea

Re: [bpf-next,v3,11/13] tools: bpf: make use of reallocarray

2018-07-13 Thread Guenter Roeck
On 07/13/2018 05:07 PM, Jakub Kicinski wrote: On Fri, 13 Jul 2018 16:53:05 -0700, Guenter Roeck wrote: Hi, On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote: reallocarray() is a safer variant of realloc which checks for multiplication overflow in case of array allocation. Since i

Re: [bpf-next,v3,11/13] tools: bpf: make use of reallocarray

2018-07-13 Thread Jakub Kicinski
On Fri, 13 Jul 2018 16:53:05 -0700, Guenter Roeck wrote: > Hi, > > On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote: > > reallocarray() is a safer variant of realloc which checks for > > multiplication overflow in case of array allocation. Since it's > > not available in Glibc < 2.2

Re: [bpf-next,v3,11/13] tools: bpf: make use of reallocarray

2018-07-13 Thread Guenter Roeck
Hi, On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote: > reallocarray() is a safer variant of realloc which checks for > multiplication overflow in case of array allocation. Since it's > not available in Glibc < 2.26 import kernel's overflow.h and > add a static inline implementation