Re: [SCTP]: Always linearise packet on input

2006-10-31 Thread Vlad Yasevich
Sridhar Samudrala wrote: > On Tue, 2006-10-31 at 09:36 -0500, Vlad Yasevich wrote: >> Herbert Xu wrote: >>> Hi Sridhar: >>> >>> On Mon, Oct 30, 2006 at 05:31:24PM -0800, Sridhar Samudrala wrote: I think we currently assume atleast the SCTP header and the data chunk header to be in the skb

Re: [SCTP]: Always linearise packet on input

2006-10-31 Thread Sridhar Samudrala
On Tue, 2006-10-31 at 09:36 -0500, Vlad Yasevich wrote: > Herbert Xu wrote: > > Hi Sridhar: > > > > On Mon, Oct 30, 2006 at 05:31:24PM -0800, Sridhar Samudrala wrote: > >> I think we currently assume atleast the SCTP header and the data > >> chunk header to be in the skb head. > >> But we do handl

Re: [SCTP]: Always linearise packet on input

2006-10-31 Thread Vlad Yasevich
Herbert Xu wrote: > Hi Sridhar: > > On Mon, Oct 30, 2006 at 05:31:24PM -0800, Sridhar Samudrala wrote: >> I think we currently assume atleast the SCTP header and the data >> chunk header to be in the skb head. >> But we do handle skbs with data in the frag_list. >> Not sure about skb's with paged

Re: [SCTP]: Always linearise packet on input

2006-10-30 Thread Herbert Xu
Hi Sridhar: On Mon, Oct 30, 2006 at 05:31:24PM -0800, Sridhar Samudrala wrote: > > I think we currently assume atleast the SCTP header and the data > chunk header to be in the skb head. > But we do handle skbs with data in the frag_list. > Not sure about skb's with paged fragments. You can't ass

Re: [SCTP]: Always linearise packet on input

2006-10-30 Thread Sridhar Samudrala
On Sun, 2006-10-29 at 23:46 -0800, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Mon, 30 Oct 2006 18:11:28 +1100 > > > [SCTP]: Always linearise packet on input > ... > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > I'll

Re: [SCTP]: Always linearise packet on input

2006-10-29 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 30 Oct 2006 18:11:28 +1100 > [SCTP]: Always linearise packet on input ... > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> I'll apply this, thanks a lot. > Sridhar, could you please organise an audit of SCTP to make sur

[SCTP]: Always linearise packet on input

2006-10-29 Thread Herbert Xu
Hi Dave: [SCTP]: Always linearise packet on input I was looking at a RHEL5 bug report involving Xen and SCTP (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212550). It turns out that SCTP wasn't written to handle skb fragments at all. The absence of any calls to skb_may_pull is test