Re: [RTNETLINK]: Add nested compat attribute

2007-06-26 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 26 Jun 2007 12:04:21 +0200 > David Miller wrote: > > Meanwhile, Patrick please clear up the situation :-) > > > Attached is both an incremental patch and a complete replacement, > please take whichever you like better :) I applied the increme

Re: [RTNETLINK]: Add nested compat attribute

2007-06-26 Thread Patrick McHardy
David Miller wrote: > Meanwhile, Patrick please clear up the situation :-) Attached is both an incremental patch and a complete replacement, please take whichever you like better :) [RTNETLINK]: Add nested compat attribute Add a nested compat attribute type that can be used to conv

Re: [RTNETLINK]: Add nested compat attribute

2007-06-26 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: > It looks like the one Patrick resent was the older version that requires > a typecast. This is the function prototype currently in the kernel: Oops, sorry, I messed that up. Will fix immediately. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Mon, 25 Jun 2007 16:23:02 -0700 > It looks like the one Patrick resent was the older version that requires > a typecast. This is the function prototype currently in the kernel: > > +extern int rtattr_parse_nested_compat(struct rtattr *tb[]

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
> From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Mon, 25 Jun 2007 23:08:09 +0200 > > > David Miller wrote: > > > > > >> I've been using this patch and the IPROUTE2 patches Patrick has > > >> proposed with no issues. Can someone else look at these patches > > >> when they have time? I'd be i

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
> -Original Message- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Monday, June 25, 2007 2:30 PM > To: Waskiewicz Jr, Peter P > Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; > [EMAIL PROTECTED] > Subject: Re: [RTNETLINK]: Add nested compat attribute >

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Mon, 25 Jun 2007 14:33:12 -0700 > I'm putting them into the latest 2.6.23 tree right now - I'll have them > tested and sent upstream later today. Please repull as I just put Patrick's RTNETLINK patch in "for real this time" :-) - To unsubsc

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 25 Jun 2007 23:08:09 +0200 > David Miller wrote: > > > >> I've been using this patch and the IPROUTE2 patches Patrick has proposed > >> with no issues. Can someone else look at these patches when they have > >> time? I'd be interested in seein

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Mon, 25 Jun 2007 14:01:31 -0700 > Awesome Dave!! Thank you very much. :) Please get your next round of patches ready, Patrick and I can review them and barring any serious issues we can finally put this stuff in to net-2.6.23. - To unsubsc

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Patrick McHardy
the net-2.6.23 tree. You seem to have added the netlink patch for the generic netlink attributes. Peter needs the rtnetlink attribute patch since qdiscs still use the old stuff. Attached again to this mail. [RTNETLINK]: Add nested compat attribute Add a nested compat attribute type that ca

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
> From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> > Date: Mon, 25 Jun 2007 10:14:37 -0700 > > > > This patch adds a new attribute type that can be used to replace > > > non-nested attributes that contain structures by nested ones in a > > > compatible way. > > > > > > This can be used in cas

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Mon, 25 Jun 2007 10:14:37 -0700 > > This patch adds a new attribute type that can be used to > > replace non-nested attributes that contain structures by > > nested ones in a compatible way. > > > > This can be used in cases like Peter's

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
> This patch adds a new attribute type that can be used to > replace non-nested attributes that contain structures by > nested ones in a compatible way. > > This can be used in cases like Peter's who is trying to > extend sch_prio, which currently uses a fixed structure > without any holes. >

Re: [RTNETLINK]: Add nested compat attribute

2007-06-22 Thread Patrick McHardy
sizeof(*qopt))) return -EINVAL; now its: if (rtattr_parse_nested_compat(tb, TCA_PRIO_MAX, opt, qopt, sizeof(*qopt))) return -EINVAL; [RTNETLINK]: Add nested compat attribute Add a nested compat attribute type that can be used to convert attrib

[RTNETLINK]: Add nested compat attribute

2007-06-22 Thread Patrick McHardy
ng to nested attributes makes sure that the next person won't run into the same problem. [RTNETLINK]: Add nested compat attribute Add a nested compat attribute type that can be used to convert attributes that contain a structure to nested attributes in a backwards compatible way. The attribute