Re: [RFT v3] geneve: implement support for IPv6-based tunnels

2015-10-01 Thread Jesse Gross
On Thu, Oct 1, 2015 at 1:03 PM, John W. Linville wrote: > On Thu, Oct 01, 2015 at 09:26:59AM -0700, Jesse Gross wrote: >> On Wed, Sep 30, 2015 at 11:34 AM, John W. Linville >> wrote: >> > +static struct dst_entry *geneve_get_dst(struct sk_buff *skb, >> >> It might be worth clarifying this name -

Re: [RFT v3] geneve: implement support for IPv6-based tunnels

2015-10-01 Thread John W. Linville
On Thu, Oct 01, 2015 at 09:26:59AM -0700, Jesse Gross wrote: > On Wed, Sep 30, 2015 at 11:34 AM, John W. Linville > wrote: > > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > > index 8f5c02eed47d..291d3d7754a8 100644 > > --- a/drivers/net/geneve.c > > +++ b/drivers/net/geneve.c > > +#de

Re: [RFT v3] geneve: implement support for IPv6-based tunnels

2015-10-01 Thread Jesse Gross
On Wed, Sep 30, 2015 at 11:34 AM, John W. Linville wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 8f5c02eed47d..291d3d7754a8 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > +#define GENEVE_F_IPV6 0x0001 I wasn't sure why we needed this fl

Re: [RFT v3] geneve: implement support for IPv6-based tunnels

2015-10-01 Thread Jiri Benc
On Wed, 30 Sep 2015 14:34:05 -0400, John W. Linville wrote: > +#if IS_ENABLED(CONFIG_IPV6) > +static netdev_tx_t geneve6_xmit_skb(struct sk_buff *skb, struct net_device > *dev, > + struct ip_tunnel_info *info) > +{ > + struct geneve_dev *geneve = netdev_priv(dev

Re: [RFT v3] geneve: implement support for IPv6-based tunnels

2015-09-30 Thread kbuild test robot
Hi John, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-s2-10010927 (attached as .config) reproduce: git checkout c1211d3ada9fc6f89f657c1d9c870de3baff506e # save the attached .config to linux build tree make AR

[RFT v3] geneve: implement support for IPv6-based tunnels

2015-09-30 Thread John W. Linville
Signed-off-by: John W. Linville --- v3: - declare geneve_remote_unspec as static v2: - do not require remote address for tx on metadata tunnels - pass correct sockaddr family to udp_tun_rx_dst in geneve_rx - accommodate both ipv4 and ipv6 sockets open on same tunnel - move declaration of geneve_