Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-07-07 Thread Ido Schimmel
On Fri, Jul 05, 2019 at 12:01:49PM -0400, Vivien Didelot wrote: > Hi Ido, > > On Sun, 23 Jun 2019 07:09:52 +, Ido Schimmel wrote: > > > Russell, Ido, Florian, so far I understand that a multicast-unaware > > > bridge must flood unknown traffic everywhere (CPU included); > > > and a multicast-

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-07-05 Thread Vivien Didelot
Hi Ido, On Sun, 23 Jun 2019 07:09:52 +, Ido Schimmel wrote: > > Russell, Ido, Florian, so far I understand that a multicast-unaware > > bridge must flood unknown traffic everywhere (CPU included); > > and a multicast-aware bridge must only flood its ports if their > > mcast_flood is on, and k

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-29 Thread Andrew Lunn
> We have some tests under tools/testing/selftests/net/forwarding/, but > not so much for MC. However, even if such tests were to be contributed, > would you be able to run them on your hardware? I remember that in the > past you complained about the number of required ports. Hi Ido Most devices

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-29 Thread Ido Schimmel
On Sun, Jun 23, 2019 at 10:44:27AM +0300, Ido Schimmel wrote: > On Sun, Jun 23, 2019 at 08:26:05AM +0100, Russell King - ARM Linux admin > wrote: > > On Sun, Jun 23, 2019 at 07:09:52AM +, Ido Schimmel wrote: > > > When multicast snooping is enabled unregistered multicast traffic should > > > o

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-29 Thread Ido Schimmel
On Sun, Jun 23, 2019 at 06:48:41AM +, Ido Schimmel wrote: > On Thu, Jun 20, 2019 at 07:24:47PM -0700, Florian Fainelli wrote: > > On 6/20/2019 4:56 PM, Vivien Didelot wrote: > > > This patch adds support for enabling or disabling the flooding of > > > unknown multicast traffic on the CPU ports,

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-23 Thread Ido Schimmel
On Sun, Jun 23, 2019 at 08:26:05AM +0100, Russell King - ARM Linux admin wrote: > On Sun, Jun 23, 2019 at 07:09:52AM +, Ido Schimmel wrote: > > When multicast snooping is enabled unregistered multicast traffic should > > only be flooded to mrouter ports. > > Given that IPv6 relies upon multica

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-23 Thread Russell King - ARM Linux admin
On Sun, Jun 23, 2019 at 07:09:52AM +, Ido Schimmel wrote: > When multicast snooping is enabled unregistered multicast traffic should > only be flooded to mrouter ports. Given that IPv6 relies upon multicast working, and multicast snooping is a kernel configuration option, and MLD messages will

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-23 Thread Ido Schimmel
On Fri, Jun 21, 2019 at 05:29:52PM -0400, Vivien Didelot wrote: > On Thu, 20 Jun 2019 19:24:47 -0700, Florian Fainelli > wrote: > > > This patch adds support for enabling or disabling the flooding of > > > unknown multicast traffic on the CPU ports, depending on the value > > > of the switchdev S

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-22 Thread Ido Schimmel
On Thu, Jun 20, 2019 at 07:24:47PM -0700, Florian Fainelli wrote: > On 6/20/2019 4:56 PM, Vivien Didelot wrote: > > This patch adds support for enabling or disabling the flooding of > > unknown multicast traffic on the CPU ports, depending on the value > > of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 05:29:52PM -0400, Vivien Didelot wrote: > Russell, Ido, Florian, so far I understand that a multicast-unaware > bridge must flood unknown traffic everywhere (CPU included); ^ multicast > and a multicast-aware bridge must on

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-21 Thread Vivien Didelot
On Thu, 20 Jun 2019 19:24:47 -0700, Florian Fainelli wrote: > > This patch adds support for enabling or disabling the flooding of > > unknown multicast traffic on the CPU ports, depending on the value > > of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED attribute. > > > > This allows the us

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-20 Thread Florian Fainelli
On 6/20/2019 4:56 PM, Vivien Didelot wrote: > This patch adds support for enabling or disabling the flooding of > unknown multicast traffic on the CPU ports, depending on the value > of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED attribute. > > This allows the user to prevent the CPU to

[RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-20 Thread Vivien Didelot
This patch adds support for enabling or disabling the flooding of unknown multicast traffic on the CPU ports, depending on the value of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED attribute. This allows the user to prevent the CPU to be flooded with a lot of undesirable traffic that the net