Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Jakub Kicinski
On Tue, 15 Jan 2019 19:05:01 +0100, Jiri Pirko wrote: > > For versions there may be FW communication required, and reading stuff > > out of flash. I bit of overhead for users who just want the list of > > devlink instances. > > > > Having in under dev but as a separate command seems quite nice ind

Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Jiri Pirko
Tue, Jan 15, 2019 at 06:53:52PM CET, jakub.kicin...@netronome.com wrote: >On Tue, 15 Jan 2019 09:20:11 +0100, Jiri Pirko wrote: >> > static void help(void) >> > { >> >pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" >> > " devlink [ -f[orce] ] -b[atch] filename\n"

Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Jakub Kicinski
On Tue, 15 Jan 2019 15:00:46 +0100, Andrew Lunn wrote: > I could have a line card implementing a port which has version > information, as well as version information for the backplane which > would be under dev. I'd argue a line card is not a port, so adding port info for line cards is, again, tak

Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Jakub Kicinski
On Tue, 15 Jan 2019 09:20:11 +0100, Jiri Pirko wrote: > > static void help(void) > > { > > pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" > >" devlink [ -f[orce] ] -b[atch] filename\n" > >- "where OBJECT := { dev | port | sb | monitor | dpipe | reso

Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Jiri Pirko
Tue, Jan 15, 2019 at 03:00:46PM CET, and...@lunn.ch wrote: >On Tue, Jan 15, 2019 at 09:20:11AM +0100, Jiri Pirko wrote: >> [...] >> >> > static void help(void) >> > { >> >pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" >> > " devlink [ -f[orce] ] -b[atch] filena

Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Andrew Lunn
On Tue, Jan 15, 2019 at 09:20:11AM +0100, Jiri Pirko wrote: > [...] > > > static void help(void) > > { > > pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" > >" devlink [ -f[orce] ] -b[atch] filename\n" > >- "where OBJECT := { dev | port | sb | monit

Re: [RFC iproute2-next] devlink: add info subcommand

2019-01-15 Thread Jiri Pirko
[...] > static void help(void) > { > pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" > " devlink [ -f[orce] ] -b[atch] filename\n" >- "where OBJECT := { dev | port | sb | monitor | dpipe | resource >| region }\n" >+ "where OBJECT

[RFC iproute2-next] devlink: add info subcommand

2019-01-14 Thread Jakub Kicinski
Add support for reading the device serial number and versions from the kernel. Signed-off-by: Jakub Kicinski --- devlink/devlink.c | 223 +++- man/man8/devlink-info.8 | 75 ++ man/man8/devlink.8 | 5 + 3 files changed, 302 insertions(