Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-28 Thread Eelco Chaudron
On 28 Jun 2019, at 9:46, Toke Høiland-Jørgensen wrote: "Eelco Chaudron" writes: On 26 Jun 2019, at 10:38, Jesper Dangaard Brouer wrote: On Tue, 25 Jun 2019 03:19:22 + "Machulsky, Zorik" wrote: On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: On Sun, 23 Jun 2019 10:06:4

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-28 Thread Jesper Dangaard Brouer
On Wed, 26 Jun 2019 11:20:45 -0400 Willem de Bruijn wrote: > On Wed, Jun 26, 2019 at 11:01 AM Toke Høiland-Jørgensen > wrote: > > Jesper Dangaard Brouer writes: > > > On Wed, 26 Jun 2019 13:52:16 +0200 > > > Toke Høiland-Jørgensen wrote: > > > > > >> Jesper Dangaard Brouer writes: > > >>

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-28 Thread Jesper Dangaard Brouer
On Fri, 28 Jun 2019 09:14:39 +0200 "Eelco Chaudron" wrote: > On 26 Jun 2019, at 10:38, Jesper Dangaard Brouer wrote: > > > On Tue, 25 Jun 2019 03:19:22 + > > "Machulsky, Zorik" wrote: > > > >> On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" > >> wrote: > >> > >> On Sun, 23 Jun 2019 1

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-28 Thread Toke Høiland-Jørgensen
"Eelco Chaudron" writes: > On 26 Jun 2019, at 10:38, Jesper Dangaard Brouer wrote: > >> On Tue, 25 Jun 2019 03:19:22 + >> "Machulsky, Zorik" wrote: >> >>> On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" >>> wrote: >>> >>> On Sun, 23 Jun 2019 10:06:49 +0300 wrote: >>> >>> > This com

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-28 Thread Eelco Chaudron
On 26 Jun 2019, at 10:38, Jesper Dangaard Brouer wrote: On Tue, 25 Jun 2019 03:19:22 + "Machulsky, Zorik" wrote: On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: On Sun, 23 Jun 2019 10:06:49 +0300 wrote: > This commit implements the basic functionality of drop/pass l

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-27 Thread Jonathan Lemon
On 26 Jun 2019, at 13:00, Jesper Dangaard Brouer wrote: On Wed, 26 Jun 2019 09:42:07 -0700 "Jonathan Lemon" wrote: If all packets are collected together (like the bulk queue does), and then passed to XDP, this could easily be made backwards compatible. If the XDP program isn't 'multi-frag' a

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jesper Dangaard Brouer
On Wed, 26 Jun 2019 09:42:07 -0700 "Jonathan Lemon" wrote: > If all packets are collected together (like the bulk queue does), and > then passed to XDP, this could easily be made backwards compatible. > If the XDP program isn't 'multi-frag' aware, then each packet is just > passed in individu

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jonathan Lemon
On 26 Jun 2019, at 8:20, Willem de Bruijn wrote: On Wed, Jun 26, 2019 at 11:01 AM Toke Høiland-Jørgensen wrote: Jesper Dangaard Brouer writes: On Wed, 26 Jun 2019 13:52:16 +0200 Toke Høiland-Jørgensen wrote: Jesper Dangaard Brouer writes: On Tue, 25 Jun 2019 03:19:22 + "Machul

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jesper Dangaard Brouer
On Wed, 26 Jun 2019 17:14:32 +0200 Toke Høiland-Jørgensen wrote: > Jesper Dangaard Brouer writes: > > > On Wed, 26 Jun 2019 13:52:16 +0200 > > Toke Høiland-Jørgensen wrote: > > > >> Jesper Dangaard Brouer writes: > >> > >> > On Tue, 25 Jun 2019 03:19:22 + > >> > "Machulsky, Zorik" w

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Willem de Bruijn
On Wed, Jun 26, 2019 at 11:01 AM Toke Høiland-Jørgensen wrote: > > Jesper Dangaard Brouer writes: > > > On Wed, 26 Jun 2019 13:52:16 +0200 > > Toke Høiland-Jørgensen wrote: > > > >> Jesper Dangaard Brouer writes: > >> > >> > On Tue, 25 Jun 2019 03:19:22 + > >> > "Machulsky, Zorik" wrote: >

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Wed, 26 Jun 2019 13:52:16 +0200 > Toke Høiland-Jørgensen wrote: > >> Jesper Dangaard Brouer writes: >> >> > On Tue, 25 Jun 2019 03:19:22 + >> > "Machulsky, Zorik" wrote: >> > >> >> On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: >> >> >> >>

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Wed, 26 Jun 2019 13:52:16 +0200 > Toke Høiland-Jørgensen wrote: > >> Jesper Dangaard Brouer writes: >> >> > On Tue, 25 Jun 2019 03:19:22 + >> > "Machulsky, Zorik" wrote: >> > >> >> On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: >> >> >> >>

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jesper Dangaard Brouer
On Wed, 26 Jun 2019 13:52:16 +0200 Toke Høiland-Jørgensen wrote: > Jesper Dangaard Brouer writes: > > > On Tue, 25 Jun 2019 03:19:22 + > > "Machulsky, Zorik" wrote: > > > >> On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: > >> > >> On Sun, 23 Jun 2019 10:06:49 +0300 wrote: >

Re: XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Tue, 25 Jun 2019 03:19:22 + > "Machulsky, Zorik" wrote: > >> On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: >> >> On Sun, 23 Jun 2019 10:06:49 +0300 wrote: >> >> > This commit implements the basic functionality of drop/pass logic in

XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support)

2019-06-26 Thread Jesper Dangaard Brouer
On Tue, 25 Jun 2019 03:19:22 + "Machulsky, Zorik" wrote: > On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: > > On Sun, 23 Jun 2019 10:06:49 +0300 wrote: > > > This commit implements the basic functionality of drop/pass logic in the > > ena driver. > > Usua

Re: [RFC V1 net-next 1/1] net: ena: implement XDP drop support

2019-06-24 Thread Machulsky, Zorik
On 6/23/19, 7:21 AM, "Jesper Dangaard Brouer" wrote: On Sun, 23 Jun 2019 10:06:49 +0300 wrote: > This commit implements the basic functionality of drop/pass logic in the > ena driver. Usually we require a driver to implement all the XDP return codes, before we ac

Re: [RFC V1 net-next 1/1] net: ena: implement XDP drop support

2019-06-23 Thread Maciej Fijalkowski
On Sun, 23 Jun 2019 10:06:49 +0300 wrote: > From: Sameeh Jubran > > This commit implements the basic functionality of drop/pass logic in the > ena driver. > > Signed-off-by: Sameeh Jubran > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 83 +++- > drivers/net/ethernet/a

Re: [RFC V1 net-next 1/1] net: ena: implement XDP drop support

2019-06-23 Thread David Ahern
On 6/23/19 1:06 AM, same...@amazon.com wrote: > +static int ena_xdp_set(struct net_device *netdev, struct bpf_prog *prog) > +{ > + struct ena_adapter *adapter = netdev_priv(netdev); > + struct bpf_prog *old_bpf_prog; > + int i; > + > + if (ena_xdp_allowed(adapter)) { > +

Re: [RFC V1 net-next 1/1] net: ena: implement XDP drop support

2019-06-23 Thread Jesper Dangaard Brouer
On Sun, 23 Jun 2019 10:06:49 +0300 wrote: > This commit implements the basic functionality of drop/pass logic in the > ena driver. Usually we require a driver to implement all the XDP return codes, before we accept it. But as Daniel and I discussed with Zorik during NetConf[1], we are going to

Re: [RFC V1 net-next 1/1] net: ena: implement XDP drop support

2019-06-23 Thread Jesper Dangaard Brouer
I'm very happy to see progress with XDP for the ENA driver. On Sun, 23 Jun 2019 10:06:49 +0300 wrote: > @@ -888,6 +959,15 @@ static struct sk_buff *ena_rx_skb(struct ena_ring > *rx_ring, > va = page_address(rx_info->page) + rx_info->page_offset; > prefetch(va + NET_IP_ALIGN); >

[RFC V1 net-next 1/1] net: ena: implement XDP drop support

2019-06-23 Thread sameehj
From: Sameeh Jubran This commit implements the basic functionality of drop/pass logic in the ena driver. Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 83 +++- drivers/net/ethernet/amazon/ena/ena_netdev.h | 29 +++ 2 files changed, 111 inse