Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 13:07 +0200, Thomas Graf wrote: > On 07/07/16 at 10:36pm, Jiri Kosina wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index f45929c..630838e 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -52,6 +52,7 @@ >

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Thomas Graf
On 07/07/16 at 10:36pm, Jiri Kosina wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index f45929c..630838e 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -52,6 +52,7 @@ > #include > #include > #include > +#include > > struct n

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Jiri Kosina
On Fri, 8 Jul 2016, Eric Dumazet wrote: > > diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c > > index fdc9de2..0f70ecc 100644 > > --- a/net/ipv6/ip6_gre.c > > +++ b/net/ipv6/ip6_gre.c > > @@ -62,11 +62,11 @@ module_param(log_ecn_error, bool, 0644); > > MODULE_PARM_DESC(log_ecn_error, "Log pa

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Eric Dumazet
On Thu, 2016-07-07 at 22:36 +0200, Jiri Kosina wrote: > From: Jiri Kosina > > Convert the per-device linked list into a hashtable. The primary > motivation for this change is that currently, we're not tracking all the > qdiscs in hierarchy (e.g. excluding default qdiscs), as the lookup > perfo

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Jiri Kosina
On Thu, 7 Jul 2016, Craig Gallek wrote: > This sort of seems like it's just side-stepping the problem. Given > that the size of this hash table is fixed, the lookup time of this > operation is still going to approach linear as the number of qdiscs > increases. That's true; however the primary

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-07 Thread Craig Gallek
On Thu, Jul 7, 2016 at 4:36 PM, Jiri Kosina wrote: > From: Jiri Kosina > > Convert the per-device linked list into a hashtable. The primary > motivation for this change is that currently, we're not tracking all the > qdiscs in hierarchy (e.g. excluding default qdiscs), as the lookup > performed o

[RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-07 Thread Jiri Kosina
From: Jiri Kosina Convert the per-device linked list into a hashtable. The primary motivation for this change is that currently, we're not tracking all the qdiscs in hierarchy (e.g. excluding default qdiscs), as the lookup performed over the linked list by qdisc_match_from_root() is rather ex