Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-27 Thread Linus Walleij
On Thu, Dec 17, 2020 at 2:59 AM Vladimir Oltean wrote: > It should be the driver's business to logically separate its VLAN > offloading into a preparation and a commit phase, and some drivers don't > need / can't do this. > > So remove the transactional shim from DSA and let drivers to propagate

Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-18 Thread Kurt Kanzenbach
Hi Vladimir, On Thu Dec 17 2020, Vladimir Oltean wrote: > It should be the driver's business to logically separate its VLAN > offloading into a preparation and a commit phase, and some drivers don't > need / can't do this. > > So remove the transactional shim from DSA and let drivers to propagate

Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-17 Thread Vladimir Oltean
On Thu, Dec 17, 2020 at 01:04:26PM +0200, Vladimir Oltean wrote: > On Thu, Dec 17, 2020 at 03:58:19AM +0200, Vladimir Oltean wrote: > > It should be the driver's business to logically separate its VLAN > > offloading into a preparation and a commit phase, and some drivers don't > > need / can't do

Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-17 Thread Vladimir Oltean
On Thu, Dec 17, 2020 at 03:58:19AM +0200, Vladimir Oltean wrote: > It should be the driver's business to logically separate its VLAN > offloading into a preparation and a commit phase, and some drivers don't > need / can't do this. > > So remove the transactional shim from DSA and let drivers to p

Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > It should be the driver's business to logically separate its VLAN > offloading into a preparation and a commit phase, and some drivers don't > need / can't do this. > > So remove the transactional shim from DSA and let drivers to propagate > error

[RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-16 Thread Vladimir Oltean
It should be the driver's business to logically separate its VLAN offloading into a preparation and a commit phase, and some drivers don't need / can't do this. So remove the transactional shim from DSA and let drivers to propagate errors directly from the .port_vlan_add callback. Signed-off-by: