Re: [RFC PATCH net-next 5/9] net: dsa: remove the transactional logic from MDB entries

2020-12-17 Thread Vladimir Oltean
On Thu, Dec 17, 2020 at 03:58:18AM +0200, Vladimir Oltean wrote: > For many drivers, the .port_mdb_prepare callback was not a good opportunity > to avoid any error condition, and they would suppress errors found during > the actual commit phase. > > Where a logical separation between the prepare a

Re: [RFC PATCH net-next 5/9] net: dsa: remove the transactional logic from MDB entries

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > For many drivers, the .port_mdb_prepare callback was not a good opportunity > to avoid any error condition, and they would suppress errors found during > the actual commit phase. > > Where a logical separation between the prepare and the commit ph

[RFC PATCH net-next 5/9] net: dsa: remove the transactional logic from MDB entries

2020-12-16 Thread Vladimir Oltean
For many drivers, the .port_mdb_prepare callback was not a good opportunity to avoid any error condition, and they would suppress errors found during the actual commit phase. Where a logical separation between the prepare and the commit phase existed, the function that used to implement the .port_