Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-30 Thread David Ahern
Hi Tom: On 8/29/15 12:02 PM, Tom Herbert wrote: To begin with, can we abstract out the need for common code to know about the VRF device (netif_index_is_vrf). Looking more closely at udp_semdmsg code, there's seems to be some potential problems: My intention to address your udp_sendmsg comment

Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-29 Thread Tom Herbert
> Cumulus Networks is invested in the VRF solution, and we will be here for > the long haul. We want a feature complete, performant and stable solution > for open networking. My preference is for a built-in solution rather than a > bolted on one and I am trying to do that by engaging the community

Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-29 Thread David Ahern
On 8/28/15 10:14 PM, David Miller wrote: From: Eric Dumazet Date: Fri, 28 Aug 2015 18:31:07 -0700 On Fri, 2015-08-28 at 17:34 -0700, David Ahern wrote: Currently the VRF driver registers an Rx handler for enslaved devices. The handler switches the skb->dev to the VRF device and sends it back

Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-29 Thread David Ahern
On 8/28/15 10:14 PM, David Miller wrote: From: David Ahern Date: Fri, 28 Aug 2015 17:34:20 -0700 Currently the VRF driver registers an Rx handler for enslaved devices. The handler switches the skb->dev to the VRF device and sends it back for another pass. While this works fine a side effect is

Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-28 Thread David Miller
From: Eric Dumazet Date: Fri, 28 Aug 2015 18:31:07 -0700 > On Fri, 2015-08-28 at 17:34 -0700, David Ahern wrote: >> Currently the VRF driver registers an Rx handler for enslaved devices. >> The handler switches the skb->dev to the VRF device and sends it back for >> another pass. While this works

Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-28 Thread David Miller
From: David Ahern Date: Fri, 28 Aug 2015 17:34:20 -0700 > Currently the VRF driver registers an Rx handler for enslaved devices. > The handler switches the skb->dev to the VRF device and sends it back for > another pass. While this works fine a side effect is that it bypasses > netfilter with the

Re: [RFC PATCH net-next 0/3] L3 RX handler

2015-08-28 Thread Eric Dumazet
On Fri, 2015-08-28 at 17:34 -0700, David Ahern wrote: > Currently the VRF driver registers an Rx handler for enslaved devices. > The handler switches the skb->dev to the VRF device and sends it back for > another pass. While this works fine a side effect is that it bypasses > netfilter with the skb

[RFC PATCH net-next 0/3] L3 RX handler

2015-08-28 Thread David Ahern
Currently the VRF driver registers an Rx handler for enslaved devices. The handler switches the skb->dev to the VRF device and sends it back for another pass. While this works fine a side effect is that it bypasses netfilter with the skb set to the original device. Looking at how to provide that f