Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-28 Thread Florian Fainelli
rnel.org >> Cc: j...@resnulli.us; da...@davemloft.net; f.faine...@gmail.com; >> ro...@cumulusnetworks.com >> Subject: [RFC PATCH net-next 0/2] Add new switchdev device class >> >> From: Scott Feldman >> >> >> So what next? I'd rather not build APIs around

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-28 Thread Andrew Lunn
> So with kobj, a device can have a parent. So I experimented with my > RFC patch and changed register_switchdev to take a parent switchdev > arg, which is NULL for leaf switchdevs: > > int register_switchdev(struct switchdev *sdev, const char *name, >struct switchdev *par

RE: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Arad, Ronen
.@cumulusnetworks.com >Subject: [RFC PATCH net-next 0/2] Add new switchdev device class > >From: Scott Feldman > > >So what next? I'd rather not build APIs around sysfs, so we need a netlink >API >we can build on top of this. It's not really rtnl. Maybe genl wo

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread David Miller
From: sfel...@gmail.com Date: Thu, 27 Aug 2015 00:16:44 -0700 > Comments? No fundamental objections from me. I just want to reiterate one thing I think Jiri said. There are other kinds of devices which make up this kind of hierarchy. I can think of two examples involving bonafide ethernet ports

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Scott Feldman
On Thu, Aug 27, 2015 at 2:06 AM, Andrew Lunn wrote: > On Thu, Aug 27, 2015 at 01:42:24AM -0700, Scott Feldman wrote: >> On Thu, Aug 27, 2015 at 12:45 AM, Andrew Lunn wrote: >> >> I don't know about how this overlaps with DSA platform_class. Florian? >> > >> > There is some overlap with DSA, but

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread John W. Linville
On Thu, Aug 27, 2015 at 12:16:44AM -0700, sfel...@gmail.com wrote: > From: Scott Feldman > > In the switchdev model, we use netdevs to represent switchdev ports, but we > have no representation for the switch itself. So, introduce a new switchdev > device class so we can define semantics and pro

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Andrew Lunn
On Thu, Aug 27, 2015 at 01:42:24AM -0700, Scott Feldman wrote: > On Thu, Aug 27, 2015 at 12:45 AM, Andrew Lunn wrote: > >> I don't know about how this overlaps with DSA platform_class. Florian? > > > > There is some overlap with DSA, but the current DSA model, with > > respect to probing, is brok

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Scott Feldman
On Thu, Aug 27, 2015 at 12:45 AM, Andrew Lunn wrote: >> I don't know about how this overlaps with DSA platform_class. Florian? > > There is some overlap with DSA, but the current DSA model, with > respect to probing, is broken. So this might be interesting as a way > towards fix that. > > One thi

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Jiri Pirko
Thu, Aug 27, 2015 at 10:17:54AM CEST, sfel...@gmail.com wrote: >On Thu, Aug 27, 2015 at 12:27 AM, Jiri Pirko wrote: >> Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: >>>From: Scott Feldman >>> >>>In the switchdev model, we use netdevs to represent switchdev ports, but we >>>have n

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Scott Feldman
On Thu, Aug 27, 2015 at 12:36 AM, John Fastabend wrote: > On 15-08-27 12:16 AM, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> In the switchdev model, we use netdevs to represent switchdev ports, but we >> have no representation for the switch itself. So, introduce a new switchdev >> devi

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Scott Feldman
On Thu, Aug 27, 2015 at 12:27 AM, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: >>From: Scott Feldman >> >>In the switchdev model, we use netdevs to represent switchdev ports, but we >>have no representation for the switch itself. So, introduce a new switchde

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread John Fastabend
On 15-08-27 12:51 AM, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 09:43:54AM CEST, john.fastab...@gmail.com wrote: >> On 15-08-27 12:27 AM, Jiri Pirko wrote: >>> Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: From: Scott Feldman In the switchdev model, we use netdevs to

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread John Fastabend
[...] >> >> The structure I used previously which looks like your prototype I think, >> >> (https://github.com/jrfastab/rocker-net-next/blob/master/include/uapi/linux/if_flow.h) >> >> * [NFL_TABLE_IDENTIFIER_TYPE] >> * [NFL_TABLE_IDENTIFIER] >> * [NFL_TABLE_TABLES] >> * [NFL_TABLE] >> * [N

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Andrew Lunn
> I don't know about how this overlaps with DSA platform_class. Florian? There is some overlap with DSA, but the current DSA model, with respect to probing, is broken. So this might be interesting as a way towards fix that. One thing to keep in mind is the D in DSA. You talk about switch, singul

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Jiri Pirko
Thu, Aug 27, 2015 at 09:43:54AM CEST, john.fastab...@gmail.com wrote: >On 15-08-27 12:27 AM, Jiri Pirko wrote: >> Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: >>> From: Scott Feldman >>> >>> In the switchdev model, we use netdevs to represent switchdev ports, but we >>> have no r

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Jiri Pirko
Thu, Aug 27, 2015 at 09:36:20AM CEST, john.fastab...@gmail.com wrote: >On 15-08-27 12:16 AM, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> In the switchdev model, we use netdevs to represent switchdev ports, but we >> have no representation for the switch itself. So, introduce a new swit

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread John Fastabend
On 15-08-27 12:27 AM, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> In the switchdev model, we use netdevs to represent switchdev ports, but we >> have no representation for the switch itself. So, introduce a new switchdev >> devic

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread John Fastabend
On 15-08-27 12:16 AM, sfel...@gmail.com wrote: > From: Scott Feldman > > In the switchdev model, we use netdevs to represent switchdev ports, but we > have no representation for the switch itself. So, introduce a new switchdev > device class so we can define semantics and programming interfaces

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread Jiri Pirko
Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >In the switchdev model, we use netdevs to represent switchdev ports, but we >have no representation for the switch itself. So, introduce a new switchdev >device class so we can define semantics and programming

[RFC PATCH net-next 0/2] Add new switchdev device class

2015-08-27 Thread sfeldma
From: Scott Feldman In the switchdev model, we use netdevs to represent switchdev ports, but we have no representation for the switch itself. So, introduce a new switchdev device class so we can define semantics and programming interfaces for the switch itself. Switchdev device class isn't tied