Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ

2018-01-09 Thread Eric Dumazet
On Sat, 2018-01-06 at 20:22 +0100, Natale Patriciello wrote: > Thank you, Eric and David, for the time spent in reviewing our work. > Some comments inline: > > On 05/01/18 at 03:53am, Eric Dumazet wrote: > > > I do not want to add yet another condition in fast path. > > Just put an arbitrary larg

Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ

2018-01-06 Thread Natale Patriciello
Thank you, Eric and David, for the time spent in reviewing our work. Some comments inline: On 05/01/18 at 03:53am, Eric Dumazet wrote: > I do not want to add yet another condition in fast path. > Just put an arbitrary large value in the existing sysctl, no need for > extra code. Due to the minim

Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ

2018-01-05 Thread Eric Dumazet
On Fri, 2018-01-05 at 12:32 +0100, Natale Patriciello wrote: > The original TSQ algorithm limits the number of packets in qdisc/devices to > two packets / or ~1 ms. With this commit, two sysctl knobs are added to > allow tuning the number of packets or the ms value. > > Signed-off-by: Natale Patri

[RFC PATCH 3/3] tcp: Add tunable parameters for TSQ

2018-01-05 Thread Natale Patriciello
The original TSQ algorithm limits the number of packets in qdisc/devices to two packets / or ~1 ms. With this commit, two sysctl knobs are added to allow tuning the number of packets or the ms value. Signed-off-by: Natale Patriciello Cc: Carlo Augusto Grazia Tested-by: Carlo Augusto Grazia ---