Re: [RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Eric Dumazet
On 6/18/20 1:25 PM, Michal Kubecek wrote: > On Thu, Jun 18, 2020 at 11:12:57AM -0700, Eric Dumazet wrote: >> On 6/18/20 9:09 AM, Jonathan Lemon wrote: >>> Adds a "rx_hd_split" private flag parameter to ethtool. >>> >>> This enables header splitting, and sets up the fragment mappings. >>> The fea

Re: [RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Eric Dumazet
On 6/18/20 2:50 PM, Jonathan Lemon wrote: > In the same vein, there should be a similar > setting for the TCP option padding on the sender side. We had no need for such hack in the TCP stack :)

Re: [RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Eric Dumazet
On 6/18/20 2:50 PM, Jonathan Lemon wrote: > On Thu, Jun 18, 2020 at 11:12:57AM -0700, Eric Dumazet wrote: >> >> >> On 6/18/20 9:09 AM, Jonathan Lemon wrote: >>> Adds a "rx_hd_split" private flag parameter to ethtool. >>> >>> This enables header splitting, and sets up the fragment mappings. >>> T

Re: [RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Jonathan Lemon
On Thu, Jun 18, 2020 at 11:12:57AM -0700, Eric Dumazet wrote: > > > On 6/18/20 9:09 AM, Jonathan Lemon wrote: > > Adds a "rx_hd_split" private flag parameter to ethtool. > > > > This enables header splitting, and sets up the fragment mappings. > > The feature is currently only enabled for netgpu

Re: [RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Michal Kubecek
On Thu, Jun 18, 2020 at 11:12:57AM -0700, Eric Dumazet wrote: > On 6/18/20 9:09 AM, Jonathan Lemon wrote: > > Adds a "rx_hd_split" private flag parameter to ethtool. > > > > This enables header splitting, and sets up the fragment mappings. > > The feature is currently only enabled for netgpu chann

Re: [RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Eric Dumazet
On 6/18/20 9:09 AM, Jonathan Lemon wrote: > Adds a "rx_hd_split" private flag parameter to ethtool. > > This enables header splitting, and sets up the fragment mappings. > The feature is currently only enabled for netgpu channels. We are using a similar idea (pseudo header split) to implement

[RFC PATCH 06/21] mlx5: add header_split flag

2020-06-18 Thread Jonathan Lemon
Adds a "rx_hd_split" private flag parameter to ethtool. This enables header splitting, and sets up the fragment mappings. The feature is currently only enabled for netgpu channels. Signed-off-by: Jonathan Lemon --- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 15 +++ .../net/ethernet/mel