RE: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-29 Thread David Laight
From: Jakub Kicinski > Sent: 25 August 2017 20:34 > > On Fri, 25 Aug 2017 08:24:49 -0700, Jacob Keller wrote: > > Under some circumstances, such as with many stacked devices, it is > > possible that dev_hard_start_xmit will bundle many packets together, and > > mark them all with xmit_more. > > Ex

RE: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-28 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Jakub Kicinski > Sent: Friday, August 25, 2017 12:34 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org > Subject: Re: [RFC PATCH] net: limit maximum numb

RE: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-28 Thread Keller, Jacob E
Subject: Re: [RFC PATCH] net: limit maximum number of packets to mark with > xmit_more > > On Fri, Aug 25, 2017 at 8:58 AM, Stephen Hemminger > wrote: > > On Fri, 25 Aug 2017 15:36:22 + > > "Waskiewicz Jr, Peter" wrote: > > > >> On 8/25/17 11

Re: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-25 Thread Alexander Duyck
On Fri, Aug 25, 2017 at 8:58 AM, Stephen Hemminger wrote: > On Fri, 25 Aug 2017 15:36:22 + > "Waskiewicz Jr, Peter" wrote: > >> On 8/25/17 11:25 AM, Jacob Keller wrote: >> > Under some circumstances, such as with many stacked devices, it is >> > possible that dev_hard_start_xmit will bundle m

Re: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-25 Thread Jakub Kicinski
On Fri, 25 Aug 2017 08:24:49 -0700, Jacob Keller wrote: > Under some circumstances, such as with many stacked devices, it is > possible that dev_hard_start_xmit will bundle many packets together, and > mark them all with xmit_more. Excuse my ignorance but what are those stacked devices? Could the

RE: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-25 Thread Keller, Jacob E
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, August 25, 2017 8:58 AM > To: Waskiewicz Jr, Peter > Cc: Keller, Jacob E ; netdev@vger.kernel.org > Subject: Re: [RFC PATCH] net: limit maximum number of packets to mar

Re: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-25 Thread Stephen Hemminger
On Fri, 25 Aug 2017 15:36:22 + "Waskiewicz Jr, Peter" wrote: > On 8/25/17 11:25 AM, Jacob Keller wrote: > > Under some circumstances, such as with many stacked devices, it is > > possible that dev_hard_start_xmit will bundle many packets together, and > > mark them all with xmit_more. > > >

Re: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-25 Thread Waskiewicz Jr, Peter
On 8/25/17 11:25 AM, Jacob Keller wrote: > Under some circumstances, such as with many stacked devices, it is > possible that dev_hard_start_xmit will bundle many packets together, and > mark them all with xmit_more. > > Most drivers respond to xmit_more by skipping tail bumps on packet > rings, o

[RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-25 Thread Jacob Keller
Under some circumstances, such as with many stacked devices, it is possible that dev_hard_start_xmit will bundle many packets together, and mark them all with xmit_more. Most drivers respond to xmit_more by skipping tail bumps on packet rings, or similar behavior as long as xmit_more is set. This