Re: [RFC 1/3] devlink: Add config parameter get/set operations

2017-10-13 Thread Jiri Pirko
Thu, Oct 12, 2017 at 08:12:48PM CEST, andrew.gospoda...@broadcom.com wrote: >On Thu, Oct 12, 2017 at 04:03:17PM +0200, Jiri Pirko wrote: >> Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.l...@broadcom.com wrote: >> >Add support for config parameter get/set commands. Initially used by >> >bnxt driver,

Re: [RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Andy Gospodarek
On Thu, Oct 12, 2017 at 04:03:17PM +0200, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.l...@broadcom.com wrote: > >Add support for config parameter get/set commands. Initially used by > >bnxt driver, but other drivers can use the same, or new, attributes. > >The config_get() and

Re: [RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Steve Lin
Jiri, Thanks for your feedback below and in your other response. I will make some changes to address those issues and resubmit. Thanks again! Steve On Thu, Oct 12, 2017 at 10:03 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.l...@broadcom.com wrote: >>Add support for conf

Re: [RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Jiri Pirko
Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.l...@broadcom.com wrote: >+ >+ /* When config doesn't take effect until next reboot (config >+ * just changed NVM which isn't read until boot, for example), >+ * this attribute should be set by the driver. >+ */ >+ DEVLINK_ATT

Re: [RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Jiri Pirko
Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.l...@broadcom.com wrote: >Add support for config parameter get/set commands. Initially used by >bnxt driver, but other drivers can use the same, or new, attributes. >The config_get() and config_set() operations operate as expected, but >note that the dri

[RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Steve Lin
Add support for config parameter get/set commands. Initially used by bnxt driver, but other drivers can use the same, or new, attributes. The config_get() and config_set() operations operate as expected, but note that the driver implementation of the config_set() operation can indicate whether a re