Re: [RFC 1/1] constify tcp congestion

2017-08-08 Thread Stephen Hemminger
On Wed, 02 Aug 2017 01:13:09 -0700 Eric Dumazet wrote: > On Wed, 2017-08-02 at 00:56 -0700, Eric Dumazet wrote: > > > Also, I am not convinced this would be a good move, since you added an > > extra structure which is not const anyway. > > Actually, this extra structure might be needed if we

Re: [RFC 1/1] constify tcp congestion

2017-08-02 Thread Eric Dumazet
On Wed, 2017-08-02 at 00:56 -0700, Eric Dumazet wrote: > Also, I am not convinced this would be a good move, since you added an > extra structure which is not const anyway. Actually, this extra structure might be needed if we want to move the tcp congestion sysctls to net namespace.

Re: [RFC 1/1] constify tcp congestion

2017-08-02 Thread Eric Dumazet
On Tue, 2017-08-01 at 19:49 -0700, Stephen Hemminger wrote: > Split the TCP congestion ops structure into const and mutable portions. > Put the list pointers, key and a copy of the flags in new tcp_congestion_entry > structure. ... > -void tcp_unregister_congestion_control(struct tcp_congestion_o

[RFC 1/1] constify tcp congestion

2017-08-01 Thread Stephen Hemminger
Split the TCP congestion ops structure into const and mutable portions. Put the list pointers, key and a copy of the flags in new tcp_congestion_entry structure. Signed-off-by: Stephen Hemminger --- include/net/tcp.h| 10 ++- net/ipv4/tcp.c | 2 - net/ipv4/tcp_bbr.c |