Re: [RFC] separate SIOCGIFCONF from the rest of dev_ioctl()

2017-06-26 Thread Al Viro
On Mon, Jun 26, 2017 at 10:25:14PM +0200, Johannes Berg wrote: > On Mon, 2017-06-26 at 18:40 +0100, Al Viro wrote: > > > Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. > > Separating that codepath from the rest of dev_ioctl() allows both > > to simplify dev_ioctl() itself (all oth

Re: [RFC] separate SIOCGIFCONF from the rest of dev_ioctl()

2017-06-26 Thread Johannes Berg
On Mon, 2017-06-26 at 18:40 +0100, Al Viro wrote: > Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. > Separating that codepath from the rest of dev_ioctl() allows both > to simplify dev_ioctl() itself (all other cases work with struct > ifreq *) > *and* seriously simplify the com

[RFC] separate SIOCGIFCONF from the rest of dev_ioctl()

2017-06-26 Thread Al Viro
[ This is just an RFC - I'm not asking to apply it at the moment. Are there any objections in principle to that change? ] Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. Separating that codepath from the rest of dev_ioctl() allows both to simplify dev_ioctl() itself (all other