Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-25 Thread Christophe Ricard
Hi David, Pablo, I gave try to your proposed patch. Changes in netlink_getsockopt and netlink_setsockopt are working fine. Changes in netlink_ack looks not to be addressing the correct socket. I will send an updated version in few minutes. Best Regards Christophe On 25/08/2015 06:19, David Mi

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-24 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 24 Aug 2015 20:56:37 +0200 > On Mon, Aug 24, 2015 at 10:08:22AM +0200, Christophe Ricard wrote: >> Hi Scott, >> >> I think i understand the potential limitation of my solution. >> I saw something was proposed by Jiri Benc who pushed an additional flag to >> tel

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-24 Thread Pablo Neira Ayuso
On Mon, Aug 24, 2015 at 10:08:22AM +0200, Christophe Ricard wrote: > Hi Scott, > > I think i understand the potential limitation of my solution. > I saw something was proposed by Jiri Benc who pushed an additional flag to > tell if the payload can be ignored in case of an error. > http://patchwork

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-23 Thread Scott Feldman
On Sun, Aug 23, 2015 at 3:06 PM, Christophe Ricard wrote: > Currently, ACK in case of error contains a full copy of the originating > message. This can cause lost ACKs with large netlink messages, especially > after commit c05cdb1b864f ("netlink: allow large data transfers from > user-space"). > >

[RFC] netlink: netlink_ack send a capped message in case of error

2015-08-23 Thread Christophe Ricard
Currently, ACK in case of error contains a full copy of the originating message. This can cause lost ACKs with large netlink messages, especially after commit c05cdb1b864f ("netlink: allow large data transfers from user-space"). Send back a capped message instead. Signed-off-by: Christophe Ricard