Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-06 Thread Jisheng Zhang
On Tue, 6 Oct 2020 07:45:10 +0200 Heiner Kallweit wrote: > > On 05.10.2020 18:00, Florian Fainelli wrote: > > > > > > On 10/5/2020 8:54 AM, Heiner Kallweit wrote: > >> On 05.10.2020 17:41, Florian Fainelli wrote: > >>> > >>> > >>> On 10/5/2020 1:53 AM, Jisheng Zhang wrote: > On Wed,

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-05 Thread Heiner Kallweit
On 05.10.2020 18:00, Florian Fainelli wrote: > > > On 10/5/2020 8:54 AM, Heiner Kallweit wrote: >> On 05.10.2020 17:41, Florian Fainelli wrote: >>> >>> >>> On 10/5/2020 1:53 AM, Jisheng Zhang wrote: On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote: > > On 9/30/2020

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-05 Thread Florian Fainelli
On 10/5/2020 8:54 AM, Heiner Kallweit wrote: On 05.10.2020 17:41, Florian Fainelli wrote: On 10/5/2020 1:53 AM, Jisheng Zhang wrote: On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote: On 9/30/2020 1:11 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fa

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-05 Thread Heiner Kallweit
On 05.10.2020 17:41, Florian Fainelli wrote: > > > On 10/5/2020 1:53 AM, Jisheng Zhang wrote: >> On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote: >> >> >>> >>> On 9/30/2020 1:11 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fainelli wrote: > > >>>

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-05 Thread Florian Fainelli
On 10/5/2020 1:53 AM, Jisheng Zhang wrote: On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote: On 9/30/2020 1:11 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fainelli wrote: On 9/30/2020 12:09 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 05:47:43PM

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-05 Thread Jisheng Zhang
On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote: > > On 9/30/2020 1:11 PM, Andrew Lunn wrote: > > On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fainelli wrote: > >> > >> > >> On 9/30/2020 12:09 PM, Andrew Lunn wrote: > >>> On Wed, Sep 30, 2020 at 05:47:43PM +0800, Jisheng Zhang

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-09-30 Thread Florian Fainelli
On 9/30/2020 1:11 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fainelli wrote: On 9/30/2020 12:09 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 05:47:43PM +0800, Jisheng Zhang wrote: Hi, A GE phy supports pad isolation which can save power in WOL mode. But on

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-09-30 Thread Andrew Lunn
On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fainelli wrote: > > > On 9/30/2020 12:09 PM, Andrew Lunn wrote: > > On Wed, Sep 30, 2020 at 05:47:43PM +0800, Jisheng Zhang wrote: > > > Hi, > > > > > > A GE phy supports pad isolation which can save power in WOL mode. But > > > once the > > > i

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-09-30 Thread Florian Fainelli
On 9/30/2020 12:09 PM, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 05:47:43PM +0800, Jisheng Zhang wrote: Hi, A GE phy supports pad isolation which can save power in WOL mode. But once the isolation is enabled, the MAC can't send/receive pkts to/from the phy because the phy is "isolated". To

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-09-30 Thread Andrew Lunn
On Wed, Sep 30, 2020 at 05:47:43PM +0800, Jisheng Zhang wrote: > Hi, > > A GE phy supports pad isolation which can save power in WOL mode. But once the > isolation is enabled, the MAC can't send/receive pkts to/from the phy because > the phy is "isolated". To make the PHY work normally, I need to

[RFC] net: phy: add shutdown hook to struct phy_driver

2020-09-30 Thread Jisheng Zhang
Hi, A GE phy supports pad isolation which can save power in WOL mode. But once the isolation is enabled, the MAC can't send/receive pkts to/from the phy because the phy is "isolated". To make the PHY work normally, I need to move the enabling isolation to suspend hook, so far so good. But the isol