Re: [RFC] net: mvneta: 64bit platform support

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 21:45:35 Jisheng Zhang wrote: > oh, missing some code: > #ifdef CONFIG_64BIT > data = ((u64)rx_desc->reserved5 << 32) | rx_desc->buf_cookie; > #else > data = (void*)rx_desc->buf_cookie; > #endif > > Please use the upper_32_bits() and lower_32_bits() macros to split up

Re: [RFC] net: mvneta: 64bit platform support

2016-03-30 Thread Jisheng Zhang
On Wed, 30 Mar 2016 21:37:00 +0800 Jisheng Zhang wrote: > Hi all, > > Obviously, current mvneta driver can't work on 64bit platforms. For one thing > the BM feature should be explicitly disabled, I just sent out one patch for > this purpose. > > What's more, the buf_cookie in mvneta_rx_desc nee

[RFC] net: mvneta: 64bit platform support

2016-03-30 Thread Jisheng Zhang
Hi all, Obviously, current mvneta driver can't work on 64bit platforms. For one thing the BM feature should be explicitly disabled, I just sent out one patch for this purpose. What's more, the buf_cookie in mvneta_rx_desc need to be carefully considered. The driver use the buf_cookie(u32 type) t