Re: [RFC] more robust inet range checking

2007-10-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 16:33:47 -0700 > I split them into two patches: 1 is the SCTP stuff, 2 is the range stuff. > Retesting tonight. Thank you. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROT

Re: [RFC] more robust inet range checking

2007-10-10 Thread Stephen Hemminger
On Wed, 10 Oct 2007 16:31:08 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Brian Haley <[EMAIL PROTECTED]> > Date: Wed, 10 Oct 2007 15:24:20 -0400 > > > Stephen Hemminger wrote: > > > --- a/net/ipv4/udp.c 2007-10-10 08:27:00.0 -0700 > > > +++ b/net/ipv4/udp.c 2007-

Re: [RFC] more robust inet range checking

2007-10-10 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 15:24:20 -0400 > Stephen Hemminger wrote: > > --- a/net/ipv4/udp.c2007-10-10 08:27:00.0 -0700 > > +++ b/net/ipv4/udp.c2007-10-10 09:44:35.0 -0700 > > @@ -147,13 +147,13 @@ int __udp_lib_get_port(struct soc

Re: [RFC] more robust inet range checking

2007-10-10 Thread Brian Haley
Stephen Hemminger wrote: int inet_csk_bind_conflict(const struct sock *sk, const struct inet_bind_bucket *tb) @@ -77,10 +90,11 @@ int inet_csk_get_port(struct inet_hashin local_bh_disable(); if (!snum) { - int low = sysctl_local_port_range[0]

Re: [RFC] more robust inet range checking

2007-10-10 Thread Vlad Yasevich
Stephen Hemminger wrote: > More complete version of local port range checking. > > 1. Enforce that low < high when setting. > 2. Use seqlock to ensure atomic update. > 3. Add port randomization to SCTP. This is a new feature but >easier than maintaining old code that was broken if range >c

[RFC] more robust inet range checking

2007-10-10 Thread Stephen Hemminger
More complete version of local port range checking. 1. Enforce that low < high when setting. 2. Use seqlock to ensure atomic update. 3. Add port randomization to SCTP. This is a new feature but easier than maintaining old code that was broken if range changed. Signed-off-by: Stephen Hemming