Re: [RFC] ethtool netlink interface

2008-02-25 Thread Thomas Graf
* Jeff Garzik <[EMAIL PROTECTED]> 2008-02-25 12:30 > However, I would think it inconsistent to only do SSET/GSET. If others > are OK with this patch, are you open to implementing the full set of > ethtool operations? Of course, I would also provide a documented userspace api within libnl. -- To

Re: [RFC] ethtool netlink interface

2008-02-25 Thread Jeff Garzik
Thomas Graf wrote: Hello, Before I continue to finish this work I'd like to get a few comments on my implementation attempt. The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET command via netlink. The individual commands are implemented as separate functions and hooked into a tabl

[RFC] ethtool netlink interface

2008-02-25 Thread Thomas Graf
Hello, Before I continue to finish this work I'd like to get a few comments on my implementation attempt. The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET command via netlink. The individual commands are implemented as separate functions and hooked into a table holding a validate,