On Tuesday 16 May 2006 00:49, David S. Miller wrote:
> From: Rick Jones <[EMAIL PROTECTED]>
> Date: Mon, 15 May 2006 14:39:23 -0700
>
> > How about:
>
> How about, just leave it alone? :-)
Agreed. Currently it only makes a difference with slab debugging, which hurts
performance no matter what we
David S. Miller wrote:
From: Rick Jones <[EMAIL PROTECTED]>
Date: Mon, 15 May 2006 14:39:23 -0700
How about:
How about, just leave it alone? :-)
That would work too :) but I guess I figured based on the reason given
just before I posted, for why setting to L1_CACHE_SIZE was wrong that
t
From: Rick Jones <[EMAIL PROTECTED]>
Date: Mon, 15 May 2006 14:39:23 -0700
> How about:
How about, just leave it alone? :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-in
On Mon, 15 May 2006 14:39:23 -0700
Rick Jones <[EMAIL PROTECTED]> wrote:
> David S. Miller wrote:
> > From: "Randy.Dunlap" <[EMAIL PROTECTED]>
> > Date: Mon, 15 May 2006 08:02:58 -0700
> >
> >
> >>>-#define NETDEV_ALIGN32
> >>>+#define NETDEV_ALIGNL1_CACHE_BYTES
> >>>
David S. Miller wrote:
From: "Randy.Dunlap" <[EMAIL PROTECTED]>
Date: Mon, 15 May 2006 08:02:58 -0700
-#defineNETDEV_ALIGN32
+#defineNETDEV_ALIGNL1_CACHE_BYTES
#define NETDEV_ALIGN_CONST (NETDEV_ALIGN - 1)
I don't know about the fixed value of 32,
From: "Randy.Dunlap" <[EMAIL PROTECTED]>
Date: Mon, 15 May 2006 08:02:58 -0700
> > -#defineNETDEV_ALIGN32
> > +#defineNETDEV_ALIGNL1_CACHE_BYTES
> > #defineNETDEV_ALIGN_CONST (NETDEV_ALIGN - 1)
>
> I don't know about the fixed value of 32, but if this pat
On Mon, 15 May 2006 14:08:29 +0200 Christian Borntraeger wrote:
> while digging through the alloc_netdev function I asked myself why there is a
> fixed alignment for netdevices. Is there a special reason for choosing 32? If
> yes, I suggest to add a comment to the definition.
>
> If not, I suspe
while digging through the alloc_netdev function I asked myself why there is a
fixed alignment for netdevices. Is there a special reason for choosing 32? If
yes, I suggest to add a comment to the definition.
If not, I suspect cacheline alignment might be beneficial:
struct net_device contains seve
