Re: [RFC] bridge: partial rtnetlink hooks

2006-04-27 Thread Patrick McHardy
Stephen Hemminger wrote: > This is the start of adding support for rtnetlink to the bridge code. > So far it only supports accessing the list of links and notifying > about link changes. It is just a prototype to get early feedback, don't > use to build your own masterpiece yet. > > +static int b

Re: [RFC] bridge: partial rtnetlink hooks

2006-04-26 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 26 Apr 2006 10:45:21 -0700 > +struct brifinfo { > + __u8state; > + __u32 cost; > +}; > + Maybe put the __u32 first and explicitly pad out the 3 bytes after the __u8? Just to be safe. I know you use an assignment initializer, s

Re: [RFC] bridge: partial rtnetlink hooks

2006-04-26 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > --- /dev/null > +++ bridge-2.6/net/bridge/br_netlink.c [...] > +static int br_fill_ifinfo(struct sk_buff *skb, const struct net_bridge_port > *port, > + u32 pid, u32 seq, int event, unsigned int flags) > +{ [...] > +nlmsg_failur

[RFC] bridge: partial rtnetlink hooks

2006-04-26 Thread Stephen Hemminger
This is the start of adding support for rtnetlink to the bridge code. So far it only supports accessing the list of links and notifying about link changes. It is just a prototype to get early feedback, don't use to build your own masterpiece yet. --- bridge-2.6.orig/net/bridge/Makefile +++ bridge-