Re: [RFC] apparently bogus logics in unix_find_other() since 2002

2019-02-11 Thread Solar Designer
On Sun, Feb 10, 2019 at 04:24:22AM +, Al Viro wrote: > In "net/unix/af_unix.c: Set ATIME on socket inode" (back in > 2002) we'd grown something rather odd in unix_find_other(). In the > original patch it was > u=unix_find_socket_byname(sunname, len, type, hash); > -

Re: [RFC] apparently bogus logics in unix_find_other() since 2002

2019-02-10 Thread Al Viro
On Sun, Feb 10, 2019 at 04:24:15AM +, Al Viro wrote: > > Looks like that should be impossible; what am I missing here? Incidentally, > how can the quoted fragment in in unix_stream_connect() be reached with NULL > otheru->addr? After all, otheru is unix_sock of a listener; how could > we pos

[RFC] apparently bogus logics in unix_find_other() since 2002

2019-02-09 Thread Al Viro
In "net/unix/af_unix.c: Set ATIME on socket inode" (back in 2002) we'd grown something rather odd in unix_find_other(). In the original patch it was u=unix_find_socket_byname(sunname, len, type, hash); - if (!u) + if (u) { +