Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

2006-12-25 Thread Keiichi KII
Thank you for your replies and reviews. I will follow your advices. static LIST_HEAD(target_list); static DEFINE_SPINLOCK(target_list_lock); +static ssize_t show_local_ip(struct netconsole_target *nt, char *buf) +{ + return sprintf(buf, "%d.%d.%d.%d\n", HIPQUAD(nt->np.local_ip));

Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

2006-12-23 Thread Randy Dunlap
On Fri, 22 Dec 2006 21:14:36 +0900 Keiichi KII wrote: > From: Keiichi KII <[EMAIL PROTECTED]> > > --- > [changes] > 1. expand macro code as far as possible. > 2. follow kernel coding style. > 3. print proper output messeage. > 4. attach proper label for printk. > 5. integrate netpoll_lock and net

[RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

2006-12-22 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following changes. create a sysfs entry for netconsole in /sys/class/misc. This entry has elements related to netconsole as follows. You can change configuration of netconsole(writable attributes such as IP address, port number and so