subject:"\[RFC\]\[NET\] Alignment in mv643xx_eth"

Re: [RFC][NET] Alignment in mv643xx_eth

2007-02-27 Thread Jeff Garzik

Ralf Baechle wrote: The driver contains this little piece of candy: #if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE) #define ETH_DMA_ALIGN L1_CACHE_BYTES #else #define ETH_DMA_ALIGN 8 #endif Any reason why we're not using dma_get_cache_alignment() in

Re: [RFC][NET] Alignment in mv643xx_eth

2007-02-26 Thread Dale Farnsworth

On Mon, Feb 26, 2007 at 07:52:06PM +, Ralf Baechle wrote: > The driver contains this little piece of candy: > > #if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE) > #define ETH_DMA_ALIGN L1_CACHE_BYTES > #else > #define ETH_DMA_ALIGN 8 > #endif > > A

[RFC][NET] Alignment in mv643xx_eth

2007-02-26 Thread Ralf Baechle

The driver contains this little piece of candy: #if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE) #define ETH_DMA_ALIGN L1_CACHE_BYTES #else #define ETH_DMA_ALIGN 8 #endif Any reason why we're not using dma_get_cache_alignment() instead? Ralf Signed