Re: [Patch net-next v2 4/4] net_sched: kill u32_node pointer in Qdisc

2017-08-25 Thread Jiri Pirko
Fri, Aug 25, 2017 at 02:29:57PM CEST, j...@mojatatu.com wrote: >On 17-08-24 07:51 PM, Cong Wang wrote: >> It is ugly to hide a u32-filter-specific pointer inside Qdisc, >> this breaks the TC layers: >> >> 1. Qdisc is a generic representation, should not have any specific >> data of any type >>

Re: [Patch net-next v2 4/4] net_sched: kill u32_node pointer in Qdisc

2017-08-25 Thread Jamal Hadi Salim
On 17-08-24 07:51 PM, Cong Wang wrote: It is ugly to hide a u32-filter-specific pointer inside Qdisc, this breaks the TC layers: 1. Qdisc is a generic representation, should not have any specific data of any type 2. Qdisc layer is above filter layer, should only save filters in the list

Re: [Patch net-next v2 4/4] net_sched: kill u32_node pointer in Qdisc

2017-08-25 Thread Jiri Pirko
Fri, Aug 25, 2017 at 01:51:30AM CEST, xiyou.wangc...@gmail.com wrote: >It is ugly to hide a u32-filter-specific pointer inside Qdisc, >this breaks the TC layers: > >1. Qdisc is a generic representation, should not have any specific > data of any type > >2. Qdisc layer is above filter layer, shoul

[Patch net-next v2 4/4] net_sched: kill u32_node pointer in Qdisc

2017-08-24 Thread Cong Wang
It is ugly to hide a u32-filter-specific pointer inside Qdisc, this breaks the TC layers: 1. Qdisc is a generic representation, should not have any specific data of any type 2. Qdisc layer is above filter layer, should only save filters in the list of struct tcf_proto. This pointer is used