Thu, Aug 24, 2017 at 04:02:50AM CEST, xiyou.wangc...@gmail.com wrote:
>On Wed, Aug 23, 2017 at 2:38 PM, Jiri Pirko wrote:
>> I would not have to spend any time on it, if you would just follow the
>> usual workflow. Clearly, you have some problem with that. I cannot
>> say I understand it :/
>
>You
On Wed, Aug 23, 2017 at 2:38 PM, Jiri Pirko wrote:
> I would not have to spend any time on it, if you would just follow the
> usual workflow. Clearly, you have some problem with that. I cannot
> say I understand it :/
You are amazing, you still waste your time even after I said
"I can fix it"...
Wed, Aug 23, 2017 at 11:31:23PM CEST, xiyou.wangc...@gmail.com wrote:
>On Wed, Aug 23, 2017 at 2:20 PM, Jiri Pirko wrote:
>> Wed, Aug 23, 2017 at 11:14:15PM CEST, xiyou.wangc...@gmail.com wrote:
>>>On Wed, Aug 23, 2017 at 1:25 PM, Jiri Pirko wrote:
>+static struct hlist_head *tc_u_common_hash
On Wed, Aug 23, 2017 at 2:20 PM, Jiri Pirko wrote:
> Wed, Aug 23, 2017 at 11:14:15PM CEST, xiyou.wangc...@gmail.com wrote:
>>On Wed, Aug 23, 2017 at 1:25 PM, Jiri Pirko wrote:
+static struct hlist_head *tc_u_common_hash;
>>>
>>> Why not use rhashtable?
>>>
>>
>>It doesn't have to be so compli
Wed, Aug 23, 2017 at 11:14:15PM CEST, xiyou.wangc...@gmail.com wrote:
>On Wed, Aug 23, 2017 at 1:25 PM, Jiri Pirko wrote:
>>>+static struct hlist_head *tc_u_common_hash;
>>
>> Why not use rhashtable?
>>
>
>It doesn't have to be so complicated, it is not fast path and
>we don't have so many qdisc's
On Wed, Aug 23, 2017 at 1:25 PM, Jiri Pirko wrote:
>>+static struct hlist_head *tc_u_common_hash;
>
> Why not use rhashtable?
>
It doesn't have to be so complicated, it is not fast path and
we don't have so many qdisc's and u32 filters in system
relatively.
>>+ tc_u_common_hash = kvmalloc_
Wed, Aug 23, 2017 at 07:58:54PM CEST, xiyou.wangc...@gmail.com wrote:
>It is ugly to hide a u32-filter-specific pointer inside Qdisc,
>this breaks the TC layers:
>
>1. Qdisc is a generic representation, should not have any specific
> data of any type
>
>2. Qdisc layer is above filter layer, shoul
It is ugly to hide a u32-filter-specific pointer inside Qdisc,
this breaks the TC layers:
1. Qdisc is a generic representation, should not have any specific
data of any type
2. Qdisc layer is above filter layer, should only save filters in
the list of struct tcf_proto.
This pointer is used
