Re: [Patch net-next] net_sched: convert idrinfo->lock from spinlock to a mutex

2018-10-05 Thread David Miller
From: Cong Wang Date: Tue, 2 Oct 2018 12:50:19 -0700 > In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take > idrinfo->lock") > we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking > with the spinlock held. Unfortunately, this causes a lot of > troubles here: > > 1. tc

Re: [Patch net-next] net_sched: convert idrinfo->lock from spinlock to a mutex

2018-10-02 Thread Ido Schimmel
On Tue, Oct 02, 2018 at 12:50:19PM -0700, Cong Wang wrote: > In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take > idrinfo->lock") > we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking > with the spinlock held. Unfortunately, this causes a lot of > troubles here: > > 1.

[Patch net-next] net_sched: convert idrinfo->lock from spinlock to a mutex

2018-10-02 Thread Cong Wang
In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take idrinfo->lock") we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking with the spinlock held. Unfortunately, this causes a lot of troubles here: 1. tcf_chain_destroy() could be called right after we queue the work but