Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-12 Thread Cong Wang
On Fri, Nov 9, 2018 at 8:16 PM David Miller wrote: > > Didn't you move this function into net/core/skbuff.c? :-) At the time when I created this patch, that patch didn't hit net-next yet. :) > > Please respin. Sure. I will send v2, as I need to cleanup the mixed commas and spaces too. Thanks.

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread David Miller
From: Cong Wang Date: Fri, 9 Nov 2018 11:43:33 -0800 > diff --git a/net/core/datagram.c b/net/core/datagram.c > index 57f3a6fcfc1e..d8f4d55cd6c5 100644 > --- a/net/core/datagram.c > +++ b/net/core/datagram.c > @@ -736,7 +736,7 @@ __sum16 __skb_checksum_complete_head(struct sk_buff *skb, > int l

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread Yunsheng Lin
On 2018/11/10 10:09, Cong Wang wrote: > On Fri, Nov 9, 2018 at 6:02 PM Yunsheng Lin wrote: >> >> On 2018/11/10 9:42, Cong Wang wrote: >>> On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote: On 2018/11/10 3:43, Cong Wang wrote: > Currently netdev_rx_csum_fault() only shows a device na

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread Cong Wang
On Fri, Nov 9, 2018 at 6:02 PM Yunsheng Lin wrote: > > On 2018/11/10 9:42, Cong Wang wrote: > > On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote: > >> > >> On 2018/11/10 3:43, Cong Wang wrote: > >>> Currently netdev_rx_csum_fault() only shows a device name, > >>> we need more information about t

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread Yunsheng Lin
On 2018/11/10 9:42, Cong Wang wrote: > On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote: >> >> On 2018/11/10 3:43, Cong Wang wrote: >>> Currently netdev_rx_csum_fault() only shows a device name, >>> we need more information about the skb for debugging. >>> >>> Sample output: >>> >>> ens3: hw csu

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread Cong Wang
On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote: > > On 2018/11/10 3:43, Cong Wang wrote: > > Currently netdev_rx_csum_fault() only shows a device name, > > we need more information about the skb for debugging. > > > > Sample output: > > > > ens3: hw csum failure > > dev features: 0x00

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread Yunsheng Lin
On 2018/11/10 3:43, Cong Wang wrote: > Currently netdev_rx_csum_fault() only shows a device name, > we need more information about the skb for debugging. > > Sample output: > > ens3: hw csum failure > dev features: 0x00014b89 > skb len=84 data_len=0 gso_size=0 gso_type=0 ip_summed=0 cs

[Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread Cong Wang
Currently netdev_rx_csum_fault() only shows a device name, we need more information about the skb for debugging. Sample output: ens3: hw csum failure dev features: 0x00014b89 skb len=84 data_len=0 gso_size=0 gso_type=0 ip_summed=0 csum=0, csum_complete_sw=0, csum_valid=0 Signed-off-b