Re: [Patch net-next] audit: remove useless synchronize_net()

2016-12-01 Thread David Miller
From: Cong Wang Date: Tue, 29 Nov 2016 09:14:56 -0800 > netlink kernel socket is protected by refcount, not RCU. > Its rcv path is neither protected by RCU. So the synchronize_net() > is just pointless. > > Cc: Richard Guy Briggs > Signed-off-by: Cong Wang Applied, thanks.

Re: [Patch net-next] audit: remove useless synchronize_net()

2016-11-30 Thread Cong Wang
On Wed, Nov 30, 2016 at 1:16 AM, Richard Guy Briggs wrote: > On 2016-11-29 09:14, Cong Wang wrote: >> netlink kernel socket is protected by refcount, not RCU. >> Its rcv path is neither protected by RCU. So the synchronize_net() >> is just pointless. > > If I understand correctly, xfrm_user_net_ex

Re: [Patch net-next] audit: remove useless synchronize_net()

2016-11-30 Thread Richard Guy Briggs
On 2016-11-29 09:14, Cong Wang wrote: > netlink kernel socket is protected by refcount, not RCU. > Its rcv path is neither protected by RCU. So the synchronize_net() > is just pointless. If I understand correctly, xfrm_user_net_exit() usage of RCU_INIT_POINTER() and synchronize_net() is similarly

[Patch net-next] audit: remove useless synchronize_net()

2016-11-29 Thread Cong Wang
netlink kernel socket is protected by refcount, not RCU. Its rcv path is neither protected by RCU. So the synchronize_net() is just pointless. Cc: Richard Guy Briggs Signed-off-by: Cong Wang --- kernel/audit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/audit.c