Re: [Patch net] smc: disallow TCP_ULP in smc_setsockopt()

2021-04-13 Thread Karsten Graul
On 10/04/2021 20:17, Cong Wang wrote: > From: Cong Wang > > syzbot is able to setup kTLS on an SMC socket, which coincidentally > uses sk_user_data too, later, kTLS treats it as psock so triggers a > refcnt warning. The cause is that smc_setsockopt() simply calls > TCP setsockopt(). I do not thin

Re: [Patch net] smc: disallow TCP_ULP in smc_setsockopt()

2021-04-12 Thread Cong Wang
On Sun, Apr 11, 2021 at 11:52 PM Karsten Graul wrote: > > > > On 10/04/2021 20:17, Cong Wang wrote: > > From: Cong Wang > > > > syzbot is able to setup kTLS on an SMC socket, which coincidentally > > uses sk_user_data too, later, kTLS treats it as psock so triggers a > > refcnt warning. The cause

Re: [Patch net] smc: disallow TCP_ULP in smc_setsockopt()

2021-04-11 Thread Karsten Graul
On 10/04/2021 20:17, Cong Wang wrote: > From: Cong Wang > > syzbot is able to setup kTLS on an SMC socket, which coincidentally > uses sk_user_data too, later, kTLS treats it as psock so triggers a > refcnt warning. The cause is that smc_setsockopt() simply calls > TCP setsockopt(). I do not t

[Patch net] smc: disallow TCP_ULP in smc_setsockopt()

2021-04-10 Thread Cong Wang
From: Cong Wang syzbot is able to setup kTLS on an SMC socket, which coincidentally uses sk_user_data too, later, kTLS treats it as psock so triggers a refcnt warning. The cause is that smc_setsockopt() simply calls TCP setsockopt(). I do not think it makes sense to setup kTLS on top of SMC, so w