Re: [Patch net] net_sched: remove tcf_block_put_deferred()

2017-11-01 Thread Jiri Pirko
Tue, Oct 31, 2017 at 10:47:48PM CET, xiyou.wangc...@gmail.com wrote: >On Tue, Oct 31, 2017 at 3:40 AM, Jiri Pirko wrote: >> Mon, Oct 30, 2017 at 07:10:09PM CET, xiyou.wangc...@gmail.com wrote: >>>In commit 7aa0045dadb6 ("net_sched: introduce a workqueue for RCU callbacks >>>of tc filter") >>>I de

Re: [Patch net] net_sched: remove tcf_block_put_deferred()

2017-10-31 Thread Cong Wang
On Tue, Oct 31, 2017 at 3:40 AM, Jiri Pirko wrote: > Mon, Oct 30, 2017 at 07:10:09PM CET, xiyou.wangc...@gmail.com wrote: >>In commit 7aa0045dadb6 ("net_sched: introduce a workqueue for RCU callbacks >>of tc filter") >>I defer tcf_chain_flush() to a workqueue, this causes a use-after-free >>becau

Re: [Patch net] net_sched: remove tcf_block_put_deferred()

2017-10-31 Thread Jiri Pirko
Mon, Oct 30, 2017 at 07:10:09PM CET, xiyou.wangc...@gmail.com wrote: >In commit 7aa0045dadb6 ("net_sched: introduce a workqueue for RCU callbacks of >tc filter") >I defer tcf_chain_flush() to a workqueue, this causes a use-after-free >because qdisc is already destroyed after we queue this work. >

Re: [Patch net] net_sched: remove tcf_block_put_deferred()

2017-10-30 Thread David Miller
From: Cong Wang Date: Mon, 30 Oct 2017 11:10:09 -0700 > In commit 7aa0045dadb6 ("net_sched: introduce a workqueue for RCU callbacks > of tc filter") > I defer tcf_chain_flush() to a workqueue, this causes a use-after-free > because qdisc is already destroyed after we queue this work. > > The tc

[Patch net] net_sched: remove tcf_block_put_deferred()

2017-10-30 Thread Cong Wang
In commit 7aa0045dadb6 ("net_sched: introduce a workqueue for RCU callbacks of tc filter") I defer tcf_chain_flush() to a workqueue, this causes a use-after-free because qdisc is already destroyed after we queue this work. The tcf_block_put_deferred() is no longer necessary after we get RTNL for