Re: [Patch net] net_sched: fix backward compatibility for TCA_ACT_KIND

2019-10-08 Thread Jakub Kicinski
On Mon, 7 Oct 2019 13:26:29 -0700, Cong Wang wrote: > For TCA_ACT_KIND, we have to keep the backward compatibility too, > and rely on nla_strlcpy() to check and terminate the string with > a NUL. > > Note for TC actions, nla_strcmp() is already used to compare kind > strings, so we don't need to

Re: [Patch net] net_sched: fix backward compatibility for TCA_ACT_KIND

2019-10-08 Thread Marcelo Ricardo Leitner
On Mon, Oct 07, 2019 at 01:26:29PM -0700, Cong Wang wrote: > For TCA_ACT_KIND, we have to keep the backward compatibility too, > and rely on nla_strlcpy() to check and terminate the string with > a NUL. > > Note for TC actions, nla_strcmp() is already used to compare kind > strings, so we don't ne

[Patch net] net_sched: fix backward compatibility for TCA_ACT_KIND

2019-10-07 Thread Cong Wang
For TCA_ACT_KIND, we have to keep the backward compatibility too, and rely on nla_strlcpy() to check and terminate the string with a NUL. Note for TC actions, nla_strcmp() is already used to compare kind strings, so we don't need to fix other places. Fixes: 199ce850ce11 ("net_sched: add policy va