Re: [Patch net] net: drop skb on failure in ip_check_defrag()

2018-11-01 Thread David Miller
From: Cong Wang Date: Thu, 1 Nov 2018 12:02:37 -0700 > Most callers of pskb_trim_rcsum() simply drop the skb when > it fails, however, ip_check_defrag() still continues to pass > the skb up to stack. This is suspicious. > > In ip_check_defrag(), after we learn the skb is an IP fragment, > passi

Re: [Patch net] net: drop skb on failure in ip_check_defrag()

2018-11-01 Thread Eric Dumazet
On 11/01/2018 12:02 PM, Cong Wang wrote: > Most callers of pskb_trim_rcsum() simply drop the skb when > it fails, however, ip_check_defrag() still continues to pass > the skb up to stack. This is suspicious. > > In ip_check_defrag(), after we learn the skb is an IP fragment, > passing the skb t

[Patch net] net: drop skb on failure in ip_check_defrag()

2018-11-01 Thread Cong Wang
Most callers of pskb_trim_rcsum() simply drop the skb when it fails, however, ip_check_defrag() still continues to pass the skb up to stack. This is suspicious. In ip_check_defrag(), after we learn the skb is an IP fragment, passing the skb to callers makes no sense, because callers expect fragmen